From: Jens Axboe <axboe@kernel.dk>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] cfq-iosched: algebraic simplification in cfq_prio_to_maxrq()
Date: Tue, 24 May 2011 10:13:57 +0200 [thread overview]
Message-ID: <4DDB68C5.4060708@kernel.dk> (raw)
In-Reply-To: <1306207131-2296-1-git-send-email-namhyung@gmail.com>
On 2011-05-24 05:18, Namhyung Kim wrote:
> Simplify the calculation in cfq_prio_to_maxrq(), plus replace CFQ_PRIO_LISTS to
> IOPRIO_BE_NR since they are the same and IOPRIO_BE_NR looks more reasonable in
> this context IMHO.
Double checked your math, it is indeed identical to
2*base_rq*IOPRIO_BE_NR - 2*base_rq*cfqq->ioprio. Looks a lot cleaner,
thanks.
--
Jens Axboe
prev parent reply other threads:[~2011-05-24 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 3:18 [PATCH 1/4] cfq-iosched: algebraic simplification in cfq_prio_to_maxrq() Namhyung Kim
2011-05-24 3:18 ` [PATCH 2/4] cfq-iosched: reduce bit operations in cfq_choose_req() Namhyung Kim
2011-05-24 17:34 ` Justin TerAvest
2011-05-25 2:34 ` Namhyung Kim
2011-05-24 3:18 ` [PATCH 3/4] cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add() Namhyung Kim
2011-05-24 17:32 ` Justin TerAvest
2011-05-24 3:18 ` [PATCH 4/4] cfq-iosched: free cic_index if cfqd allocation fails Namhyung Kim
2011-05-24 8:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDB68C5.4060708@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox