Re: [PATCH 4/5] oom: don't kill random process

Minchan Kim
2011-05-24T09:04:21Z

On Tue, May 24, 2011 at 5:49 PM, KOSAKI Motohiro
<kosaki.motohiro@jp.fujitsu.com> wrote:
> (2011/05/24 17:46), Minchan Kim wrote:
>> On Tue, May 24, 2011 at 10:53 AM, KOSAKI Motohiro
>> <kosaki.motohiro@jp.fujitsu.com> wrote:
>>>>> +       /*
>>>>> +        * chosen_point==1 may be a sign that root privilege bonus is too
>>>>> large
>>>>> +        * and we choose wrong task. Let's recalculate oom score without
>>>>> the
>>>>> +        * dubious bonus.
>>>>> +        */
>>>>> +       if (protect_root&&  (chosen_points == 1)) {
>>>>> +               protect_root = 0;
>>>>> +               goto retry;
>>>>> +       }
>>>>
>>>> The idea is good to me.
>>>> But once we meet it, should we give up protecting root privileged
>>>> processes?
>>>> How about decaying bonus point?
>>>
>>> After applying my patch, unprivileged process never get score-1. (note,
>>> mapping
>>> anon pages naturally makes to increase nr_ptes)
>>
>> Hmm, If I understand your code correctly, unprivileged process can get
>> a score 1 by 3% bonus.
>
> 3% bonus is for privileged process. :)

OMG. Typo.
Anyway, my point is following as.
If chose_point is 1, it means root bonus is rather big. Right?
If is is, your patch does second loop with completely ignore of bonus
for root privileged process.
My point is that let's not ignore bonus completely. Instead of it,
let's recalculate 1.5% for example.

But I don't insist on my idea.
Thanks.
--
Kind regards,
Minchan Kim