Re: [PATCH, RFC] USBIP protocol documentation

David Chang
2011-07-04T03:11:07Z

Hi Németh,

2011/6/29 David Chang <dchang@novell.com>:
> Hi,
>
> Thanks for your great effort.
> Just a little comment on UNLINK pdu size.
>
> 2011/6/28 Németh Márton <nm127@freemail.hu>:
>> From: Márton Németh <nm127@freemail.hu>
>>
>> USBIP v1.0.0 protocol documentation.
>>
>> Signed-off-by: Márton Németh <nm127@freemail.hu>
>> ---
>> +USBIP_CMD_UNLINK: Unlink an URB
>> +
>> + Offset    | Length | Value      | Meaning
>> +-----------+--------+------------+---------------------------------------------------
>> + 0         | 4      | 0x00000003 | command: URB unlink command
>> +-----------+--------+------------+---------------------------------------------------
>> + 4         | 4      |            | seqnum: URB sequence number to unlink: FIXME: is this so?
>> +-----------+--------+------------+---------------------------------------------------
>> + 8         | 4      |            | devid
>> +-----------+--------+------------+---------------------------------------------------
>> + 0xC       | 4      |            | direction: 0: USBIP_DIR_IN
>> +           |        |            |            1: USBIP_DIR_OUT
>> +-----------+--------+------------+---------------------------------------------------
>> + 0x10      | 4      |            | ep: endpoint number: zero
>> +-----------+--------+------------+---------------------------------------------------
>> + 0x14      | 4      |            | seqnum: the URB sequence number given previously
>> +           |        |            |   at USBIP_CMD_SUBMIT.seqnum field
-----------+--------+------------+---------------------------------------------------
0x30 | n | | URB data bytes. For ISO
transfers the padding
| | | between each ISO
packets is not transmitted.

>> +
>> +USBIP_RET_UNLINK: Reply for URB unlink
>> +
>> + Offset    | Length | Value      | Meaning
>> +-----------+--------+------------+---------------------------------------------------
>> + 0         | 4      | 0x00000004 | command: reply for the URB unlink command
>> +-----------+--------+------------+---------------------------------------------------
>> + 4         | 4      |            | seqnum: the unlinked URB sequence number
>> +-----------+--------+------------+---------------------------------------------------
>> + 8         | 4      |            | devid
>> +-----------+--------+------------+---------------------------------------------------
>> + 0xC       | 4      |            | direction: 0: USBIP_DIR_IN
>> +           |        |            |            1: USBIP_DIR_OUT
>> +-----------+--------+------------+---------------------------------------------------
>> + 0x10      | 4      |            | ep: endpoint number
>> +-----------+--------+------------+---------------------------------------------------
>> + 0x14      | 4      |            | status: This is the value contained in the
>> +           |        |            |   urb->status in the URB completition handler.
>> +           |        |            |   FIXME: a better explanation needed.
-----------+--------+------------+---------------------------------------------------
0x30       | n        |                 | URB data bytes. For ISO
transfers the padding
|           |                 |   between each ISO
packets is not transmitted.

Would you add this field into your path or should I send another patch
to add it?
Thanks.

Regards,
David Chang

>
> Regards,
> David Chang
>
>>
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>>
>