From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454Ab1EYMvq (ORCPT ); Wed, 25 May 2011 08:51:46 -0400 Received: from mx2.fusionio.com ([66.114.96.31]:34690 "EHLO mx2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207Ab1EYMvp (ORCPT ); Wed, 25 May 2011 08:51:45 -0400 X-ASG-Debug-ID: 1306327904-01de28096b66440001-xx1T2L X-Barracuda-Envelope-From: JAxboe@fusionio.com Message-ID: <4DDCFB5D.5080309@fusionio.com> Date: Wed, 25 May 2011 14:51:41 +0200 From: Jens Axboe MIME-Version: 1.0 To: Paul Bolle CC: "paulmck@linux.vnet.ibm.com" , Vivek Goyal , linux kernel mailing list Subject: Re: Mysterious CFQ crash and RCU References: <20110519222404.GG12600@redhat.com> <20110521210013.GJ2271@linux.vnet.ibm.com> <20110523152141.GB4019@redhat.com> <20110523153848.GC2310@linux.vnet.ibm.com> <1306189249.15900.10.camel@t41.thuisdomein> <4DDB7D36.60905@fusionio.com> <1306312155.9059.8.camel@t41.thuisdomein> <4DDCC1E4.706@fusionio.com> <1306327713.2785.2.camel@t41.thuisdomein> X-ASG-Orig-Subj: Re: Mysterious CFQ crash and RCU In-Reply-To: <1306327713.2785.2.camel@t41.thuisdomein> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Barracuda-Connect: mail1.int.fusionio.com[10.101.1.21] X-Barracuda-Start-Time: 1306327904 X-Barracuda-URL: http://10.101.1.181:8000/cgi-mod/mark.cgi X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.64662 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011-05-25 14:48, Paul Bolle wrote: > On Wed, 2011-05-25 at 10:46 +0200, Jens Axboe wrote: >> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c >> index ab7a9e6..f37e3df 100644 >> --- a/block/cfq-iosched.c >> +++ b/block/cfq-iosched.c >> @@ -1827,6 +1827,7 @@ static struct cfq_queue *cfqq_close(struct cfq_data *cfqd, >> static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd, >> struct cfq_queue *cur_cfqq) >> { >> +#if 0 >> struct cfq_queue *cfqq; >> >> if (cfq_class_idle(cur_cfqq)) >> @@ -1870,6 +1871,9 @@ static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd, >> return NULL; >> >> return cfqq; >> +#else >> + return cfqq; > > This won't compile, obviously. Did you perhaps mean > > return NULL; > > here? Eh yes, of course, sorry about that. A bit too quick on the send button. -- Jens Axboe