public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@uclinux.org>, <linux-kernel@vger.kernel.org>,
	<uclinux-dev@uclinux.org>
Subject: Re: [PATCH 4/4] m68knommu: Fix printk() format in free_initrd_mem()
Date: Thu, 26 May 2011 14:41:34 +1000	[thread overview]
Message-ID: <4DDDD9FE.7040002@snapgear.com> (raw)
In-Reply-To: <1306314660-19288-2-git-send-email-geert@linux-m68k.org>

Hi Geert,

On 25/05/11 19:11, Geert Uytterhoeven wrote:
> arch/m68k/mm/init_no.c:123: warning: format æ%dÆ expects type æintÆ, but argument 2 has type ælong unsigned intÆ
>
> And use pr_notice() while we're at it.
>
> Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org>

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


> ---
>   arch/m68k/mm/init_no.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/mm/init_no.c b/arch/m68k/mm/init_no.c
> index fdbe679..50cd12c 100644
> --- a/arch/m68k/mm/init_no.c
> +++ b/arch/m68k/mm/init_no.c
> @@ -120,7 +120,8 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>   		totalram_pages++;
>   		pages++;
>   	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
> +	pr_notice("Freeing initrd memory: %luk freed\n",
> +		  pages * (PAGE_SIZE / 1024));
>   }
>   #endif
>
> @@ -141,7 +142,7 @@ void free_initmem(void)
>   		free_page(addr);
>   		totalram_pages++;
>   	}
> -	printk(KERN_NOTICE "Freeing unused kernel memory: %ldk freed (0x%x - 0x%x)\n",
> +	pr_notice("Freeing unused kernel memory: %luk freed (0x%x - 0x%x)\n",
>   			(addr - PAGE_ALIGN((long)&__init_begin))>>  10,
>   			(int)(PAGE_ALIGN((unsigned long)(&__init_begin))),
>   			(int)(addr - PAGE_SIZE));


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2011-05-26  4:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  9:10 [PATCH 3/4] m68knommu: Make empty_zero_page "void *", like on m68k Geert Uytterhoeven
2011-05-25  9:11 ` [PATCH 4/4] m68knommu: Fix printk() format in free_initrd_mem() Geert Uytterhoeven
2011-05-26  4:41   ` Greg Ungerer [this message]
2011-05-26  4:39 ` [PATCH 3/4] m68knommu: Make empty_zero_page "void *", like on m68k Greg Ungerer
2011-05-26  5:11   ` Geert Uytterhoeven
2011-05-26  5:52     ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDDD9FE.7040002@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox