From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Greg KH <greg@kroah.com>,
David Brownell <dbrownell@users.sourceforge.net>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb-gadget: unlock data->lock mutex on error path in ep_write()
Date: Thu, 26 May 2011 13:59:57 +0400 [thread overview]
Message-ID: <4DDE249D.9000000@ru.mvista.com> (raw)
In-Reply-To: <4DDDF3EA.6050501@ispras.ru>
Hello.
On 26-05-2011 10:32, Alexey Khoroshilov wrote:
> ep_write() acquires data->lock mutex in get_ready_ep() and releases it on
> all paths except for one: when usb_endpoint_xfer_isoc() failed. The
> patch adds mutex_unlock(&data->lock) at that path.
> It is similar to commit 00cc7a5faf25b3ba5cf30fcffc62249bdd152006 for ep_read(),
Please specify that commit's summary in parens.
> it was not fixed at that time by accident.
> Found by Linux Driver Verification project (linuxtesting.org).
> Signed-off-by: Alexey Khoroshilov<khoroshilov@ispras.ru>
WBR, Sergei
next prev parent reply other threads:[~2011-05-26 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 6:32 [PATCH] usb-gadget: unlock data->lock mutex on error path in ep_write() Alexey Khoroshilov
2011-05-26 9:59 ` Sergei Shtylyov [this message]
2011-05-27 4:37 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDE249D.9000000@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox