Re: [PATCH 3/5] v2 seccomp_filters: Enable ftrace-based system call filtering

Ingo Molnar
2011-05-26T11:39:33Z

* Avi Kivity <avi@redhat.com> wrote:

> > The biggest amount of RAM is the guest RAM image - but if that is
> > mmap(SHARED) and mapped using hugepages then the pte overhead
> > from a process model is largely mitigated.
>
> That doesn't work with memory hotplug.

Why not, if we do the sensible thing and restrict the size
granularity and alignment of plugged/unplugged memory regions to 2MB?

We can fix guest Linux as well to not be stupid about the sizing of
memory hotplug requests. It does hotplug based on the memory map we
pass to it anyway.

Am i missing something obvious here?

> > Maybe even the isolation and per device access control of
> > *same-class* devices from each other is possible: with careful
> > implementation of the subsystem shared data structures. (which
> > isnt much really)
>
> Right, hardly at all in fact. The problem comes from the side-band
> issues like reset, interrupts, hotplug, and whatnot.

Yeah. There are two good aspects here i think:

- The sideband IPC overhead does not matter much, it's a side band.

- Spending the effort to isolate configuration details is worth it:
sideband code is a primary breeding ground for bugs and security
holes.

The main worry to me would be the maintainability difference: does it
result in much more complex code? As always i'm cautiously optimistic
about that: i think once we try it we can find a suitable model ...
It might even turn out to be more readable and more flexible in the
end.

Thanks,

Ingo