From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405Ab1EZOF1 (ORCPT ); Thu, 26 May 2011 10:05:27 -0400 Received: from relay1.sgi.com ([192.48.179.29]:38747 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932308Ab1EZOFZ (ORCPT ); Thu, 26 May 2011 10:05:25 -0400 Message-ID: <4DDE5E23.6040603@sgi.com> Date: Thu, 26 May 2011 07:05:23 -0700 From: Mike Travis User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Yinghai Lu Cc: Andrew Morton , Thomas Gleixner , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] irq: remove smp_affinity_list when unregister irq proc References: <4DDDE094.6050505@kernel.org> In-Reply-To: <4DDDE094.6050505@kernel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Yinghai! I (obviously) wasn't aware of this interface. -mike Yinghai Lu wrote: > got: > [ 274.239264] ------------[ cut here ]------------ > [ 274.239500] WARNING: at fs/proc/generic.c:850 remove_proc_entry+0x24c/0x27a() > [ 274.251761] remove_proc_entry: removing non-empty directory 'irq/184', leaking at least 'smp_affinity_list' > [ 274.271696] Modules linked in: > [ 274.271880] Pid: 1, comm: swapper Tainted: G W 2.6.39-tip-yh-07723-gf48dc10-dirty #1051 > [ 274.291734] Call Trace: > [ 274.291892] [] warn_slowpath_common+0x85/0x9d > [ 274.311582] [] warn_slowpath_fmt+0x46/0x48 > [ 274.311874] [] remove_proc_entry+0x24c/0x27a > [ 274.331549] [] ? vsnprintf+0x3ed/0x429 > [ 274.331798] [] ? sprintf+0x40/0x42 > [ 274.351430] [] unregister_irq_proc+0xb5/0xd2 > [ 274.351715] [] free_desc+0x22/0x61 > [ 274.371461] [] irq_free_descs+0x3b/0x73 > [ 274.371738] [] free_irq_at+0x31/0x36 > [ 274.391409] [] destroy_irq+0x74/0x7c > [ 274.391662] [] native_teardown_msi_irq+0xe/0x10 > [ 274.411407] [] default_teardown_msi_irqs+0x57/0x79 > [ 274.411735] [] free_msi_irqs+0x84/0xe2 > [ 274.431394] [] pci_disable_msi+0x35/0x39 > [ 274.431678] [] e1000e_reset_interrupt_capability+0x55/0x63 > [ 274.451420] [] e1000_test_msi_interrupt+0x30/0x114 > [ 274.451749] [] e1000_test_msi+0x6e/0xc5 > [ 274.471429] [] e1000_open+0x10f/0x1e2 > [ 274.471731] [] __dev_open+0x9c/0xca > [ 274.491282] [] __dev_change_flags+0xad/0x130 > [ 274.491561] [] dev_change_flags+0x21/0x56 > [ 274.511370] [] ic_open_devs+0xe3/0x233 > [ 274.511637] [] ip_auto_config+0xa5/0x2c0 > [ 274.531432] [] ? root_nfs_parse_addr+0xb5/0xb5 > [ 274.531780] [] do_one_initcall+0x57/0x134 > [ 274.551599] [] kernel_init+0x137/0x1bb > [ 274.551884] [] kernel_thread_helper+0x4/0x10 > [ 274.571423] [] ? retint_restore_args+0xe/0xe > [ 274.591165] [] ? start_kernel+0x3d3/0x3d3 > [ 274.591483] [] ? gs_change+0xb/0xb > [ 274.611129] ---[ end trace e07c035be3c974e5 ]--- > > caused by: > | commit 4b060420a596095869a6d7849caa798d23839cd1 > | Author: Mike Travis > | Date: Tue May 24 17:13:12 2011 -0700 > | > | bitmap, irq: add smp_affinity_list interface to /proc/irq > > it forgets to remove it in exit path > > Signed-off-by: Yinghai Lu > > --- > kernel/irq/proc.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/kernel/irq/proc.c > =================================================================== > --- linux-2.6.orig/kernel/irq/proc.c > +++ linux-2.6/kernel/irq/proc.c > @@ -352,6 +352,7 @@ void unregister_irq_proc(unsigned int ir > #ifdef CONFIG_SMP > remove_proc_entry("smp_affinity", desc->dir); > remove_proc_entry("affinity_hint", desc->dir); > + remove_proc_entry("smp_affinity_list", desc->dir); > remove_proc_entry("node", desc->dir); > #endif > remove_proc_entry("spurious", desc->dir);