* [PATCH] irq: remove smp_affinity_list when unregister irq proc
@ 2011-05-26 5:09 Yinghai Lu
2011-05-26 11:18 ` [tip:irq/urgent] irq: Remove " tip-bot for Yinghai Lu
2011-05-26 14:05 ` [PATCH] irq: remove " Mike Travis
0 siblings, 2 replies; 3+ messages in thread
From: Yinghai Lu @ 2011-05-26 5:09 UTC (permalink / raw)
To: Andrew Morton, Mike Travis, Thomas Gleixner; +Cc: linux-kernel@vger.kernel.org
got:
[ 274.239264] ------------[ cut here ]------------
[ 274.239500] WARNING: at fs/proc/generic.c:850 remove_proc_entry+0x24c/0x27a()
[ 274.251761] remove_proc_entry: removing non-empty directory 'irq/184', leaking at least 'smp_affinity_list'
[ 274.271696] Modules linked in:
[ 274.271880] Pid: 1, comm: swapper Tainted: G W 2.6.39-tip-yh-07723-gf48dc10-dirty #1051
[ 274.291734] Call Trace:
[ 274.291892] [<ffffffff8107cfa8>] warn_slowpath_common+0x85/0x9d
[ 274.311582] [<ffffffff8107d063>] warn_slowpath_fmt+0x46/0x48
[ 274.311874] [<ffffffff8118994e>] remove_proc_entry+0x24c/0x27a
[ 274.331549] [<ffffffff813336ca>] ? vsnprintf+0x3ed/0x429
[ 274.331798] [<ffffffff81333746>] ? sprintf+0x40/0x42
[ 274.351430] [<ffffffff810cde65>] unregister_irq_proc+0xb5/0xd2
[ 274.351715] [<ffffffff810ca64b>] free_desc+0x22/0x61
[ 274.371461] [<ffffffff810ca6c5>] irq_free_descs+0x3b/0x73
[ 274.371738] [<ffffffff81053bb3>] free_irq_at+0x31/0x36
[ 274.391409] [<ffffffff810553e6>] destroy_irq+0x74/0x7c
[ 274.391662] [<ffffffff81055619>] native_teardown_msi_irq+0xe/0x10
[ 274.411407] [<ffffffff8136239c>] default_teardown_msi_irqs+0x57/0x79
[ 274.411735] [<ffffffff81361c49>] free_msi_irqs+0x84/0xe2
[ 274.431394] [<ffffffff8136294d>] pci_disable_msi+0x35/0x39
[ 274.431678] [<ffffffff816574e2>] e1000e_reset_interrupt_capability+0x55/0x63
[ 274.451420] [<ffffffff81657701>] e1000_test_msi_interrupt+0x30/0x114
[ 274.451749] [<ffffffff81657853>] e1000_test_msi+0x6e/0xc5
[ 274.471429] [<ffffffff81658add>] e1000_open+0x10f/0x1e2
[ 274.471731] [<ffffffff81afed63>] __dev_open+0x9c/0xca
[ 274.491282] [<ffffffff81afef9d>] __dev_change_flags+0xad/0x130
[ 274.491561] [<ffffffff81aff0a1>] dev_change_flags+0x21/0x56
[ 274.511370] [<ffffffff82737d6b>] ic_open_devs+0xe3/0x233
[ 274.511637] [<ffffffff827394cf>] ip_auto_config+0xa5/0x2c0
[ 274.531432] [<ffffffff8273942a>] ? root_nfs_parse_addr+0xb5/0xb5
[ 274.531780] [<ffffffff810002cf>] do_one_initcall+0x57/0x134
[ 274.551599] [<ffffffff826ecf91>] kernel_init+0x137/0x1bb
[ 274.551884] [<ffffffff81c2e354>] kernel_thread_helper+0x4/0x10
[ 274.571423] [<ffffffff81c268c0>] ? retint_restore_args+0xe/0xe
[ 274.591165] [<ffffffff826ece5a>] ? start_kernel+0x3d3/0x3d3
[ 274.591483] [<ffffffff81c2e350>] ? gs_change+0xb/0xb
[ 274.611129] ---[ end trace e07c035be3c974e5 ]---
caused by:
| commit 4b060420a596095869a6d7849caa798d23839cd1
| Author: Mike Travis <travis@sgi.com>
| Date: Tue May 24 17:13:12 2011 -0700
|
| bitmap, irq: add smp_affinity_list interface to /proc/irq
it forgets to remove it in exit path
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
kernel/irq/proc.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/kernel/irq/proc.c
===================================================================
--- linux-2.6.orig/kernel/irq/proc.c
+++ linux-2.6/kernel/irq/proc.c
@@ -352,6 +352,7 @@ void unregister_irq_proc(unsigned int ir
#ifdef CONFIG_SMP
remove_proc_entry("smp_affinity", desc->dir);
remove_proc_entry("affinity_hint", desc->dir);
+ remove_proc_entry("smp_affinity_list", desc->dir);
remove_proc_entry("node", desc->dir);
#endif
remove_proc_entry("spurious", desc->dir);
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:irq/urgent] irq: Remove smp_affinity_list when unregister irq proc
2011-05-26 5:09 [PATCH] irq: remove smp_affinity_list when unregister irq proc Yinghai Lu
@ 2011-05-26 11:18 ` tip-bot for Yinghai Lu
2011-05-26 14:05 ` [PATCH] irq: remove " Mike Travis
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Yinghai Lu @ 2011-05-26 11:18 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, yinghai, travis, tglx
Commit-ID: def945eeb920b94e710574454043f080831aefe5
Gitweb: http://git.kernel.org/tip/def945eeb920b94e710574454043f080831aefe5
Author: Yinghai Lu <yinghai@kernel.org>
AuthorDate: Wed, 25 May 2011 22:09:40 -0700
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 26 May 2011 13:15:28 +0200
irq: Remove smp_affinity_list when unregister irq proc
commit 4b06042(bitmap, irq: add smp_affinity_list interface to
/proc/irq) causes the following warning:
[ 274.239500] WARNING: at fs/proc/generic.c:850 remove_proc_entry+0x24c/0x27a()
[ 274.251761] remove_proc_entry: removing non-empty directory 'irq/184',
leaking at least 'smp_affinity_list'
Remove the new file in the exit path.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Mike Travis <travis@sgi.com>
Link: http://lkml.kernel.org/r/4DDDE094.6050505@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/proc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 64e3df6..4bd4faa 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -352,6 +352,7 @@ void unregister_irq_proc(unsigned int irq, struct irq_desc *desc)
#ifdef CONFIG_SMP
remove_proc_entry("smp_affinity", desc->dir);
remove_proc_entry("affinity_hint", desc->dir);
+ remove_proc_entry("smp_affinity_list", desc->dir);
remove_proc_entry("node", desc->dir);
#endif
remove_proc_entry("spurious", desc->dir);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irq: remove smp_affinity_list when unregister irq proc
2011-05-26 5:09 [PATCH] irq: remove smp_affinity_list when unregister irq proc Yinghai Lu
2011-05-26 11:18 ` [tip:irq/urgent] irq: Remove " tip-bot for Yinghai Lu
@ 2011-05-26 14:05 ` Mike Travis
1 sibling, 0 replies; 3+ messages in thread
From: Mike Travis @ 2011-05-26 14:05 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Andrew Morton, Thomas Gleixner, linux-kernel@vger.kernel.org
Thanks Yinghai! I (obviously) wasn't aware of this interface. -mike
Yinghai Lu wrote:
> got:
> [ 274.239264] ------------[ cut here ]------------
> [ 274.239500] WARNING: at fs/proc/generic.c:850 remove_proc_entry+0x24c/0x27a()
> [ 274.251761] remove_proc_entry: removing non-empty directory 'irq/184', leaking at least 'smp_affinity_list'
> [ 274.271696] Modules linked in:
> [ 274.271880] Pid: 1, comm: swapper Tainted: G W 2.6.39-tip-yh-07723-gf48dc10-dirty #1051
> [ 274.291734] Call Trace:
> [ 274.291892] [<ffffffff8107cfa8>] warn_slowpath_common+0x85/0x9d
> [ 274.311582] [<ffffffff8107d063>] warn_slowpath_fmt+0x46/0x48
> [ 274.311874] [<ffffffff8118994e>] remove_proc_entry+0x24c/0x27a
> [ 274.331549] [<ffffffff813336ca>] ? vsnprintf+0x3ed/0x429
> [ 274.331798] [<ffffffff81333746>] ? sprintf+0x40/0x42
> [ 274.351430] [<ffffffff810cde65>] unregister_irq_proc+0xb5/0xd2
> [ 274.351715] [<ffffffff810ca64b>] free_desc+0x22/0x61
> [ 274.371461] [<ffffffff810ca6c5>] irq_free_descs+0x3b/0x73
> [ 274.371738] [<ffffffff81053bb3>] free_irq_at+0x31/0x36
> [ 274.391409] [<ffffffff810553e6>] destroy_irq+0x74/0x7c
> [ 274.391662] [<ffffffff81055619>] native_teardown_msi_irq+0xe/0x10
> [ 274.411407] [<ffffffff8136239c>] default_teardown_msi_irqs+0x57/0x79
> [ 274.411735] [<ffffffff81361c49>] free_msi_irqs+0x84/0xe2
> [ 274.431394] [<ffffffff8136294d>] pci_disable_msi+0x35/0x39
> [ 274.431678] [<ffffffff816574e2>] e1000e_reset_interrupt_capability+0x55/0x63
> [ 274.451420] [<ffffffff81657701>] e1000_test_msi_interrupt+0x30/0x114
> [ 274.451749] [<ffffffff81657853>] e1000_test_msi+0x6e/0xc5
> [ 274.471429] [<ffffffff81658add>] e1000_open+0x10f/0x1e2
> [ 274.471731] [<ffffffff81afed63>] __dev_open+0x9c/0xca
> [ 274.491282] [<ffffffff81afef9d>] __dev_change_flags+0xad/0x130
> [ 274.491561] [<ffffffff81aff0a1>] dev_change_flags+0x21/0x56
> [ 274.511370] [<ffffffff82737d6b>] ic_open_devs+0xe3/0x233
> [ 274.511637] [<ffffffff827394cf>] ip_auto_config+0xa5/0x2c0
> [ 274.531432] [<ffffffff8273942a>] ? root_nfs_parse_addr+0xb5/0xb5
> [ 274.531780] [<ffffffff810002cf>] do_one_initcall+0x57/0x134
> [ 274.551599] [<ffffffff826ecf91>] kernel_init+0x137/0x1bb
> [ 274.551884] [<ffffffff81c2e354>] kernel_thread_helper+0x4/0x10
> [ 274.571423] [<ffffffff81c268c0>] ? retint_restore_args+0xe/0xe
> [ 274.591165] [<ffffffff826ece5a>] ? start_kernel+0x3d3/0x3d3
> [ 274.591483] [<ffffffff81c2e350>] ? gs_change+0xb/0xb
> [ 274.611129] ---[ end trace e07c035be3c974e5 ]---
>
> caused by:
> | commit 4b060420a596095869a6d7849caa798d23839cd1
> | Author: Mike Travis <travis@sgi.com>
> | Date: Tue May 24 17:13:12 2011 -0700
> |
> | bitmap, irq: add smp_affinity_list interface to /proc/irq
>
> it forgets to remove it in exit path
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> kernel/irq/proc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/kernel/irq/proc.c
> ===================================================================
> --- linux-2.6.orig/kernel/irq/proc.c
> +++ linux-2.6/kernel/irq/proc.c
> @@ -352,6 +352,7 @@ void unregister_irq_proc(unsigned int ir
> #ifdef CONFIG_SMP
> remove_proc_entry("smp_affinity", desc->dir);
> remove_proc_entry("affinity_hint", desc->dir);
> + remove_proc_entry("smp_affinity_list", desc->dir);
> remove_proc_entry("node", desc->dir);
> #endif
> remove_proc_entry("spurious", desc->dir);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-26 14:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-26 5:09 [PATCH] irq: remove smp_affinity_list when unregister irq proc Yinghai Lu
2011-05-26 11:18 ` [tip:irq/urgent] irq: Remove " tip-bot for Yinghai Lu
2011-05-26 14:05 ` [PATCH] irq: remove " Mike Travis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox