From: Andi Kleen <ak@linux.intel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Måns Rullgård" <mans@mansr.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sam@ravnborg.org
Subject: Re: [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP
Date: Thu, 26 May 2011 12:58:40 -0700 [thread overview]
Message-ID: <4DDEB0F0.3010101@linux.intel.com> (raw)
In-Reply-To: <1306429854.26735.9.camel@e102144-lin.cambridge.arm.com>
> So it sounds like we might not want to enable this blindly across all
> architectures. Indeed, on ARM, it encourages the compiler to pack
> variables on the stack which leads to the weird and wonderful alignment
> situation that has been encountered in this thread.
Interesting. I'm pretty sure it didn't do that when I added the flag.
Anyways making it a CONFIG is fine for me. Just don't set it on ARM. It
should be set on x86
at least.
-Andi
next prev parent reply other threads:[~2011-05-26 19:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110523111648.10474.78396.stgit@e102109-lin.cambridge.arm.com>
[not found] ` <20110523132124.GI17672@n2100.arm.linux.org.uk>
[not found] ` <1306229953.19557.14.camel@e102109-lin.cambridge.arm.com>
[not found] ` <yw1xipt0p4i9.fsf@unicorn.mansr.com>
[not found] ` <BANLkTi=xLE9gP5YOdr9dR0DfsY1Ymzxu+w@mail.gmail.com>
[not found] ` <20110524171331.GA2941@arm.com>
[not found] ` <20110525111405.GA12010@e102109-lin.cambridge.arm.com>
[not found] ` <20110525124348.GA2340@arm.com>
[not found] ` <yw1xaaeanbxe.fsf@unicorn.mansr.com>
[not found] ` <BANLkTim2TOZgB-3Vkv5RcK572Qr07s3=CA@mail.gmail.com>
2011-05-26 17:10 ` [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP Will Deacon
2011-05-26 18:14 ` Måns Rullgård
2011-05-26 19:58 ` Andi Kleen [this message]
2011-05-26 21:03 ` Nicolas Pitre
2011-05-26 21:10 ` Andi Kleen
2011-05-26 21:26 ` Måns Rullgård
2011-05-27 10:05 ` Will Deacon
2011-05-27 16:53 ` Andi Kleen
2011-05-26 21:51 ` Russell King - ARM Linux
2011-05-26 22:29 ` Andi Kleen
2011-05-27 8:38 ` Catalin Marinas
2011-05-27 8:54 ` Russell King - ARM Linux
2011-05-27 9:51 ` Catalin Marinas
2011-05-27 9:56 ` Catalin Marinas
2011-05-27 12:46 ` Måns Rullgård
2011-05-28 15:34 ` [PATCH] Disable -fconserve-stack on ARM Andi Kleen
2011-05-31 16:30 ` Catalin Marinas
2011-05-31 18:01 ` Andi Kleen
2011-06-02 13:08 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDEB0F0.3010101@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=sam@ravnborg.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox