public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Hugh Dickins <hughd@google.com>
Cc: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: no sound in current -git
Date: Thu, 26 May 2011 13:13:56 -0700	[thread overview]
Message-ID: <4DDEB484.8030801@gmail.com> (raw)
In-Reply-To: <BANLkTik5QWiW0Wm_oygnVSJNQXpZpdRB3w@mail.gmail.com>

On 05/26/2011 11:38 AM, Hugh Dickins wrote:
> On Wed, May 25, 2011 at 11:18 PM, Justin P. Mattock
> <justinmattock@gmail.com>  wrote:
>> On 05/25/2011 10:11 PM, Dave Jones wrote:
>>>
>>> On Thu, May 26, 2011 at 12:33:38AM -0400, Dave Jones wrote:
>>>
>>>   >     >    sound over here is out as well on a macbook pro. seems gnome shell
>>>   >     >    didn't like whats being merged with the current Mainline i.g. no
>>> sound
>>>   >     >    bluetooth applet missing. will bisect when I get a chance.
>>>   >
>>>   >    Maybe it was this that just got merged..  (building now)
>>>   >
>>>   >    commit 4db70f73e56961b9bcdfd0c36c62847a18b7dbb5
>>>   >    Author: Eric Paris<eparis@redhat.com>
>>>   >    Date:   Wed May 25 19:49:18 2011 -0700
>>>   >
>>>   >        tmpfs: fix XATTR N overriding POSIX_ACL Y
>>>
>>> Yep. That fixes sound for me.
>>> Sorry for the false alarm Takashi!
>>>
>>>         Dave
>>>
>>>
>>
>> hmm.. pulled and noticed the above with git log, then did git revert for the
>> above, built, but still no sound. will do a bisect in the morning or later
>> on.
>
> That commit was the fix, not the origin of the bug, so reverting it
> was not the right thing to do!
>
> But it's only a fix if your .config has not yet been messed up (with
> CONFIG_TMPFS_XATTR and CONFIG_TMPFS_POSIX_ACL unset, though used
> somewhere for sound).
>
> So, just delete the CONFIG_TMPFS_XATTR and CONFIG_TMPFS_POSIX_ACL
> lines from your .config (perhaps you don't even get an ACL line if the
> XATTR is not set, I forget) and run "make oldconfig", this time
> choosing Y.
>
> If this was your sound problem too, then the rebuilt kernel should fix it.
>
> Apologies for inflicting this on people: Linus spotted it and got it
> fixed up a.s.a.p so it only would only affect those who pulled a tree
> yesterday.
>
> Hugh
>

probably why my bisect wasn't going anywhere..(luckily not to much time 
spent doing so) will pull when I get a chance. Thanks for letting us 
know, and Thanks to Linus for the ASAP change.

Justin P. Mattock

  reply	other threads:[~2011-05-26 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  1:34 no sound in current -git Dave Jones
2011-05-26  4:18 ` Justin P. Mattock
2011-05-26  4:33   ` Dave Jones
2011-05-26  5:11     ` Dave Jones
2011-05-26  5:22       ` Justin P. Mattock
2011-05-26  6:18       ` Justin P. Mattock
2011-05-26 18:38         ` Hugh Dickins
2011-05-26 20:13           ` Justin P. Mattock [this message]
2011-05-27  1:34           ` Justin P. Mattock
2011-05-26  6:21       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDEB484.8030801@gmail.com \
    --to=justinmattock@gmail.com \
    --cc=davej@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox