public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Linux USB list <linux-usb@vger.kernel.org>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
	"Paweł Drobek" <pawel.drobek@gmail.com>,
	"Dominik Brodowski" <linux@dominikbrodowski.net>
Subject: Re: option driver, ZTE MF_330 matches linux usb 2.0 root hub
Date: Fri, 27 May 2011 01:28:38 +0400	[thread overview]
Message-ID: <4DDEC606.4020504@msgid.tls.msk.ru> (raw)
In-Reply-To: <4DDEC269.30808@msgid.tls.msk.ru>

27.05.2011 01:13, Michael Tokarev wrote:
> I noticed that recently, all my systems started
> loading option.ko driver even if I've no single
> GSM modem anywhere around.
> 
> After some investigation I found this in option.c:
> 
> /* ZTE PRODUCTS -- alternate vendor ID */
> #define ZTE_VENDOR_ID2                          0x1d6b
> #define ZTE_PRODUCT_MF_330                      0x0002
> ...
>         { USB_DEVICE(ZTE_VENDOR_ID2, ZTE_PRODUCT_MF_330) },
> 
> 
> But this matches... "Linux Foundation 2.0 root hub",
> which has this module alias:
> 
>   usb:v1D6Bp0002d0206dc09dsc00dp00ic09isc00ip00

Forgot to mention, and to add proper Cc.  The commit
is this one:

 commit a559d2c8c1bf652ea2d0ecd6ab4a250fcdb37db8
 Author: Dominik Brodowski <linux@dominikbrodowski.net>
 Date:   Wed Apr 14 21:36:42 2010 +0200

    USB: option: add ID for ZTE MF 330

    Based on the information provided for by Paweł Drobek, add
    a second vendor ID and the correct product ID for ZTE MF 330.

    Reported-by: Paweł Drobek <pawel.drobek@gmail.com>
    Signed-off: Dominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Are the IDs really correct?  Maybe it's just a typo
after all...

It is interesting that no one noticed this so far.
Or it's just because it's difficult to search for -
"option" is really a bad search term ;)

> What are options to fix this option now? :)
> 
> Thanks!
> 
> [Cc'ing linux-kernel due to interesting USB ID clash]

/mjt

  reply	other threads:[~2011-05-26 21:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 21:13 option driver, ZTE MF_330 matches linux usb 2.0 root hub Michael Tokarev
2011-05-26 21:28 ` Michael Tokarev [this message]
2011-05-27  1:20   ` Greg KH
     [not found]     ` <BANLkTikcjXTczV2FmGcQ7BY=m_t7ep54Sw@mail.gmail.com>
2011-05-27  6:19       ` Michael Tokarev
     [not found]         ` <BANLkTikodJ4cnjJ9Lxx=zsHd-dAgPzfDrA@mail.gmail.com>
2011-05-27  9:04           ` Michael Tokarev
     [not found]             ` <BANLkTi==1WyJNACmoOxcrS6RiJ3w8Ow1zw@mail.gmail.com>
2011-05-27 10:02               ` Greg KH
2011-05-27 13:19                 ` Michael Tokarev
     [not found]                   ` <BANLkTinAip5BswLBjxyJ1O_XPnUFq=FUjw@mail.gmail.com>
2011-05-27 20:30                     ` Greg KH
2011-06-06 13:21                     ` Michael Tokarev
     [not found]                       ` <BANLkTimLfkGjFtk_GJ87_+f7fswkdmSe3Q@mail.gmail.com>
2011-06-07  4:48                         ` Paweł Drobek
2011-06-07  6:35                           ` Michael Tokarev
2011-06-08 13:32                             ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDEC606.4020504@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=pawel.drobek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox