Re: [PATCH 07/12] x86, mce: introduce mce_gather_info()

Ingo Molnar
2011-05-27T08:01:00Z

* Tony Luck <tony.luck@gmail.com> wrote:

> 2011/5/26 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
>
> > As the result the mce_get_rip() is integrated and unnecessary
> > zero-ing is removed.  This also fix an issue pointed by Tony Luck
> > that RIP is required to make some decision about error severity
> > (for SRAR errors) but it was retrieved later in the handler.
>
> To keep the credit path accurate, that was one of the pieces I
> picked up from Andi.

At minimum an explanation should be put into the code. Small, hidden
dependencies might be common job security moves in the closed source
world but this is open source ;-)

Thanks,

Ingo