From: David Daney <ddaney@caviumnetworks.com>
To: David Gibson <david@gibson.dropbear.id.au>,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code
Date: Fri, 27 May 2011 09:49:38 -0700 [thread overview]
Message-ID: <4DDFD622.1000102@caviumnetworks.com> (raw)
In-Reply-To: <20110527032402.GD7793@yookeroo.fritz.box>
On 05/26/2011 08:24 PM, David Gibson wrote:
> On Mon, May 23, 2011 at 09:47:56AM -0700, David Daney wrote:
>> On 05/20/2011 11:33 PM, David Gibson wrote:
>>> On Fri, May 20, 2011 at 03:25:38PM -0700, David Daney wrote:
>>>> To use it you need to do this in your Kconfig:
>>>>
>>>> select LIBFDT
>>>>
>>>> And in the Makefile of the code using libfdt something like:
>>>>
>>>> ccflags-y := -include linux/libfdt_env.h -I$(src)/../../../scripts/dtc/libfdt
>>>>
>>>> Signed-off-by: David Daney<ddaney@caviumnetworks.com>
>>>> ---
>>>> drivers/of/Kconfig | 3 +++
>>>> drivers/of/Makefile | 2 ++
>>>> drivers/of/libfdt/Makefile | 3 +++
>>>> drivers/of/libfdt/fdt.c | 2 ++
>>>> drivers/of/libfdt/fdt_ro.c | 2 ++
>>>> drivers/of/libfdt/fdt_wip.c | 2 ++
>>>
>>> No fdt_sw.c or fdt_rw.c?
>>>
>>
>> I had no immediate need for them. They could of course be added,
>> but that would potentially waste space.
>>
>> Let's see if I can make it into an archive library.
>
> That would be preferable. It's more or less designed to work that way
> so that everything is available without using unnecessary space in the
> binary.
>
Well, I was looking at this some more:
Grant specifically requested that this go in drivers/of/libfdt, however
I am fairly sure that building archive libraries there will require
changes to the upper level Makefile infrastructure.
If I go back to lib/libfdt, like my first version, I can easily achieve
archive library behavior, but then it is separated from from drivers/of.
Personally I am starting to like the lib/libfdt home more than
drivers/of. If Grant doesn't object, I think I will move it back there.
What do you think?
David Daney
next prev parent reply other threads:[~2011-05-27 16:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 22:25 [RFC PATCH v4 0/6] MIPS: Octeon: Use Device Tree David Daney
2011-05-20 22:25 ` [RFC PATCH v4 1/6] of: Allow scripts/dtc/libfdt to be used from kernel code David Daney
2011-05-21 6:33 ` David Gibson
2011-05-23 16:47 ` David Daney
2011-05-27 3:24 ` David Gibson
2011-05-27 16:49 ` David Daney [this message]
2011-05-27 20:12 ` Grant Likely
2011-05-20 22:25 ` [RFC PATCH v4 2/6] of: Make of_find_node_by_path() traverse /aliases for relative paths David Daney
2011-05-27 2:48 ` Grant Likely
2011-05-20 22:25 ` [RFC PATCH v4 3/6] MIPS: Octeon: Add device tree source files David Daney
2011-05-27 1:56 ` Grant Likely
2011-05-27 17:00 ` David Daney
2011-05-27 20:13 ` Grant Likely
2011-05-20 22:25 ` [RFC PATCH v4 4/6] MIPS: Prune some target specific code out of prom.c David Daney
2011-05-27 1:58 ` Grant Likely
2011-05-27 17:05 ` David Daney
2011-05-20 22:25 ` [RFC PATCH v4 5/6] MIPS: Octeon: Add irq_create_of_mapping() and GPIO interrupts David Daney
2011-05-20 22:25 ` [RFC PATCH v4 6/6] MIPS: Octeon: Initialize and fixup device tree David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDFD622.1000102@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox