From: Jens Axboe <jaxboe@fusionio.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/2] blktrace: treat flush as barrier
Date: Fri, 27 May 2011 22:17:09 +0200 [thread overview]
Message-ID: <4DE006C5.4010906@fusionio.com> (raw)
In-Reply-To: <1306509182.1351.1.camel@leonhard>
On 2011-05-27 17:13, Namhyung Kim wrote:
> 2011-05-27 (금), 09:57 -0400, Mike Snitzer:
>> On Fri, May 27, 2011 at 9:12 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>> On Fri, May 27, 2011 at 10:11:22PM +0900, Namhyung Kim wrote:
>>>> Since BARRIER requests have been converted to FLUSH/FUA, it would be
>>>> better for blktrace to recognize FLUSH requests as BARRIER for the
>>>> backward-compatibility IMHO.
>>>
>>> I'd rather see new flags for them. F and U maybe?
>>
>> Somehow I'm not surprised by your F and U suggestion -- appropriate on
>> multiple levels :)
>
> OK. I'll work on that direction.
> Thanks.
Agree on Christophs comments, we should not pretend they are the same
(since they are not). Since flush is a request on its own, F works
nicely. For FUA it's associated with a write, so F should work there too
indicating Write Fua (and easily humanly parsed as that, or Write
Flush). WU would look confusing.
--
Jens Axboe
next prev parent reply other threads:[~2011-05-27 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 13:11 [PATCH 1/2] blktrace: treat flush as barrier Namhyung Kim
2011-05-27 13:11 ` [PATCH 2/2] block: add REQ_SECURE to REQ_COMMON_MASK Namhyung Kim
2011-05-27 13:12 ` [PATCH 1/2] blktrace: treat flush as barrier Christoph Hellwig
2011-05-27 13:57 ` Mike Snitzer
2011-05-27 15:13 ` Namhyung Kim
2011-05-27 20:17 ` Jens Axboe [this message]
2011-05-27 20:27 ` Christoph Hellwig
2011-05-28 2:09 ` Namhyung Kim
2011-05-28 7:44 ` Christoph Hellwig
2011-05-31 10:27 ` Namhyung Kim
2011-05-31 10:37 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE006C5.4010906@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox