Re: [PATCH] x86: Add Dell E5420 reboot quirk

["H. Peter Anvin" <hpa@zytor.com>]

On 05/30/2011 09:52 AM, Daniel J Blueman wrote:
> On 31 May 2011 00:31, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
>>>
>>> Without this patch, rebooting is like Russian roulette; with quite a
>>> few of these laptops in the field, perhaps it is better to enable the
>>> quirk unless you think there may be an issue in the kernel preventing
>>> correct behaviour that I could debug?
>>>
>>> On the other hand, Dell may later fix the BIOS AML (seen with the
>>> excellent fwts) just as the cure for cancer is found. If they do, I'll
>>> buy whiskey too.
> 
>> Enabling the quirk is the right thing; however, if ACPI worked I'd have
>> preferred it since we just switched to ACPI as the default.
> 
> Indeed - the new and default ACPI reboot method works perfectly in
> 3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
> patch then.

Oh, okay.  Dropping the patch, then.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.