[PATCH] x86: Add Dell E5420 reboot quirk

[PATCH] x86: Add Dell E5420 reboot quirk

[Daniel J Blueman]

Rebooting on the Dell E5420 often hangs with the keyboard method,
but is reliable via the PCI method.

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 08c44b0..b16032d 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -411,6 +411,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"),
 		},
 	},
+	{
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E5420",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
+		},
+	},
 	{ }
 };
 
-- 
1.7.4.1

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[Daniel J Blueman]

On 13 May 2011 10:44, H. Peter Anvin <hpa@zytor.com> wrote:
> Daniel J Blueman <daniel.blueman@gmail.com> wrote:
>> Rebooting on the Dell E5420 often hangs with the keyboard method, but is
>> reliable via the PCI method. Signed-off-by: Daniel J Blueman
>> <daniel.blueman@gmail.com> --- arch/x86/kernel/reboot.c | 8 ++++++++ 1 files
>> changed, 8 insertions(+), 0 deletions(-) diff --git
>> a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 08c44b0..b16032d
>> 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@
>> -411,6 +411,14 @@ static struct dmi_system_id __initdata
>> pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), }, }, + {
>> + .callback = set_pci_reboot, + .ident = "Dell Latitude E5420", + .matches =
>> { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME,
>> "Latitude E5420"), + }, + }, { } }; -- 1.7.4.1

> How does it work with ACPI?

All other reboot methods including ACPI are unreliable and seem to
demonstrate the same failure probability; PCI is the only reliable
method alas.

I guess the ACPI reboot method is the supported 'official' vector (and
is what Windows uses [1]), so there must be some other constraints
preventing it work as expected, unless the ACPI tables delivered to
Linux are broken, would you say?

Daniel

[1] http://comments.gmane.org/gmane.linux.kernel/1122388
-- 
Daniel J Blueman

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[Daniel J Blueman]

Hi hpa, Thomas, Ingo,

On 13 May 2011 11:16, Daniel J Blueman <daniel.blueman@gmail.com> wrote:
> On 13 May 2011 10:44, H. Peter Anvin <hpa@zytor.com> wrote:
>> Daniel J Blueman <daniel.blueman@gmail.com> wrote:
>>> Rebooting on the Dell E5420 often hangs with the keyboard method, but is
>>> reliable via the PCI method. Signed-off-by: Daniel J Blueman
>>> <daniel.blueman@gmail.com> --- arch/x86/kernel/reboot.c | 8 ++++++++ 1 files
>>> changed, 8 insertions(+), 0 deletions(-) diff --git
>>> a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 08c44b0..b16032d
>>> 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@
>>> -411,6 +411,14 @@ static struct dmi_system_id __initdata
>>> pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), }, }, + {
>>> + .callback = set_pci_reboot, + .ident = "Dell Latitude E5420", + .matches =
>>> { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME,
>>> "Latitude E5420"), + }, + }, { } }; -- 1.7.4.1
>
>> How does it work with ACPI?
>
> All other reboot methods including ACPI are unreliable and seem to
> demonstrate the same failure probability; PCI is the only reliable
> method alas.
>
> I guess the ACPI reboot method is the supported 'official' vector (and
> is what Windows uses [1]), so there must be some other constraints
> preventing it work as expected, unless the ACPI tables delivered to
> Linux are broken, would you say?
>
> Daniel
>
> [1] http://comments.gmane.org/gmane.linux.kernel/1122388

Without this patch, rebooting is like Russian roulette; with quite a
few of these laptops in the field, perhaps it is better to enable the
quirk unless you think there may be an issue in the kernel preventing
correct behaviour that I could debug?

On the other hand, Dell may later fix the BIOS AML (seen with the
excellent fwts) just as the cure for cancer is found. If they do, I'll
buy whiskey too.

Thanks,
  Daniel
-- 
Daniel J Blueman

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[H. Peter Anvin]

On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
> 
> Without this patch, rebooting is like Russian roulette; with quite a
> few of these laptops in the field, perhaps it is better to enable the
> quirk unless you think there may be an issue in the kernel preventing
> correct behaviour that I could debug?
> 
> On the other hand, Dell may later fix the BIOS AML (seen with the
> excellent fwts) just as the cure for cancer is found. If they do, I'll
> buy whiskey too.
> 

Enabling the quirk is the right thing; however, if ACPI worked I'd have
preferred it since we just switched to ACPI as the default.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[Daniel J Blueman]

On 31 May 2011 00:31, H. Peter Anvin <hpa@zytor.com> wrote:
> On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
>>
>> Without this patch, rebooting is like Russian roulette; with quite a
>> few of these laptops in the field, perhaps it is better to enable the
>> quirk unless you think there may be an issue in the kernel preventing
>> correct behaviour that I could debug?
>>
>> On the other hand, Dell may later fix the BIOS AML (seen with the
>> excellent fwts) just as the cure for cancer is found. If they do, I'll
>> buy whiskey too.

> Enabling the quirk is the right thing; however, if ACPI worked I'd have
> preferred it since we just switched to ACPI as the default.

Indeed - the new and default ACPI reboot method works perfectly in
3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
patch then.

Thanks again,
  Daniel
-- 
Daniel J Blueman

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[H. Peter Anvin]

On 05/30/2011 09:52 AM, Daniel J Blueman wrote:
> On 31 May 2011 00:31, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
>>>
>>> Without this patch, rebooting is like Russian roulette; with quite a
>>> few of these laptops in the field, perhaps it is better to enable the
>>> quirk unless you think there may be an issue in the kernel preventing
>>> correct behaviour that I could debug?
>>>
>>> On the other hand, Dell may later fix the BIOS AML (seen with the
>>> excellent fwts) just as the cure for cancer is found. If they do, I'll
>>> buy whiskey too.
> 
>> Enabling the quirk is the right thing; however, if ACPI worked I'd have
>> preferred it since we just switched to ACPI as the default.
> 
> Indeed - the new and default ACPI reboot method works perfectly in
> 3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
> patch then.

Oh, okay.  Dropping the patch, then.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[Matthew Garrett]

On Tue, May 31, 2011 at 12:52:15AM +0800, Daniel J Blueman wrote:
> On 31 May 2011 00:31, H. Peter Anvin <hpa@zytor.com> wrote:
> > Enabling the quirk is the right thing; however, if ACPI worked I'd have
> > preferred it since we just switched to ACPI as the default.
> 
> Indeed - the new and default ACPI reboot method works perfectly in
> 3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
> patch then.

It's not entirely equivalent to the way the ACPI reboot method worked in 
previous kernels, so it should work better.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: [PATCH] x86: Add Dell E5420 reboot quirk

[Daniel J Blueman]

On 31 May 2011 00:52, Daniel J Blueman <daniel.blueman@gmail.com> wrote:
> On 31 May 2011 00:31, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 05/30/2011 07:43 AM, Daniel J Blueman wrote:
>>>
>>> Without this patch, rebooting is like Russian roulette; with quite a
>>> few of these laptops in the field, perhaps it is better to enable the
>>> quirk unless you think there may be an issue in the kernel preventing
>>> correct behaviour that I could debug?
>>>
>>> On the other hand, Dell may later fix the BIOS AML (seen with the
>>> excellent fwts) just as the cure for cancer is found. If they do, I'll
>>> buy whiskey too.
>
>> Enabling the quirk is the right thing; however, if ACPI worked I'd have
>> preferred it since we just switched to ACPI as the default.
>
> Indeed - the new and default ACPI reboot method works perfectly in
> 3.0-rc1, whereas with 2.6.39, it didn't, so no further need for this
> patch then.

I slipped up, since after finally now moving on from 2.6.39, I removed
the 'reboot=p' boot parameter; it turns out that 3.0-rc1 through -rc5
do need this workaround; and the BIOS isn't changed. Honest. So, I
didn't double-check that I had booted without it.

Can you queue up the patch please (earlier in the thread)? Probably we
should consider it for stable too, due to the hassle it brings. Let me
know if we should debug would be useful for this problem.

Thanks,
  Daniel
-- 
Daniel J Blueman

[tip:x86/urgent] x86: Make Dell Latitude E5420 use reboot=pci

[tip-bot for Daniel J Blueman]

Commit-ID:  f2b3178e66c132b81a59c5ff8b469fdee02aad4f
Gitweb:     http://git.kernel.org/tip/f2b3178e66c132b81a59c5ff8b469fdee02aad4f
Author:     Daniel J Blueman <daniel.blueman@gmail.com>
AuthorDate: Fri, 13 May 2011 09:04:59 +0800
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 21 Jul 2011 11:19:01 -0700

x86: Make Dell Latitude E5420 use reboot=pci

Rebooting on the Dell E5420 often hangs with the keyboard or ACPI
methods, but is reliable via the PCI method.

[ hpa: this was deferred because we believed for a long time that the
  recent reshuffling of the boot priorities in commit
  660e34cebf0a11d54f2d5dd8838607452355f321 fixed this platform.
  Unfortunately that turned out to be incorrect. ]

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Link: http://lkml.kernel.org/r/1305248699-2347-1-git-send-email-daniel.blueman@gmail.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 14eed21..3dfd38f 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -427,6 +427,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Latitude E5420. */
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E5420",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
+		},
+	},
 	{ }
 };
 

[tip:x86/urgent] x86: Make Dell Latitude E5420 use reboot=pci

[tip-bot for Daniel J Blueman]

Commit-ID:  b7798d28ec15d20fd34b70fa57eb13f0cf6d1ecd
Gitweb:     http://git.kernel.org/tip/b7798d28ec15d20fd34b70fa57eb13f0cf6d1ecd
Author:     Daniel J Blueman <daniel.blueman@gmail.com>
AuthorDate: Fri, 13 May 2011 09:04:59 +0800
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Thu, 21 Jul 2011 11:45:49 -0700

x86: Make Dell Latitude E5420 use reboot=pci

Rebooting on the Dell E5420 often hangs with the keyboard or ACPI
methods, but is reliable via the PCI method.

[ hpa: this was deferred because we believed for a long time that the
  recent reshuffling of the boot priorities in commit
  660e34cebf0a11d54f2d5dd8838607452355f321 fixed this platform.
  Unfortunately that turned out to be incorrect. ]

Signed-off-by: Daniel J Blueman <daniel.blueman@gmail.com>
Link: http://lkml.kernel.org/r/1305248699-2347-1-git-send-email-daniel.blueman@gmail.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: <stable@kernel.org>

---
 arch/x86/kernel/reboot.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index 14eed21..3dfd38f 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -427,6 +427,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
 		},
 	},
+	{	/* Handle problems with rebooting on the Latitude E5420. */
+		.callback = set_pci_reboot,
+		.ident = "Dell Latitude E5420",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
+		},
+	},
 	{ }
 };