* [PATCH] musb_host: compare status for negative error values
@ 2011-05-30 18:45 Németh Márton
2011-06-07 10:27 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Németh Márton @ 2011-05-30 18:45 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-usb; +Cc: LKML
From: Márton Németh <nm127@freemail.hu>
Variable d is a struct usb_iso_packet_descriptor. The status filed is usually
negative when an error happens.
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
This was not tested at all! I just found this while I was browsing the
code and it looked like a typo. Please verify and test it before aplying
this patch. If I was wrong, sorry about that.
---
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 7295e31..8b2473f 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1575,7 +1575,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
/* even if there was an error, we did the dma
* for iso_frame_desc->length
*/
- if (d->status != EILSEQ && d->status != -EOVERFLOW)
+ if (d->status != -EILSEQ && d->status != -EOVERFLOW)
d->status = 0;
if (++qh->iso_idx >= urb->number_of_packets)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] musb_host: compare status for negative error values
2011-05-30 18:45 [PATCH] musb_host: compare status for negative error values Németh Márton
@ 2011-06-07 10:27 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2011-06-07 10:27 UTC (permalink / raw)
To: Németh Márton; +Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, LKML
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
On Mon, May 30, 2011 at 08:45:42PM +0200, Németh Márton wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> Variable d is a struct usb_iso_packet_descriptor. The status filed is usually
> negative when an error happens.
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
applied to fixes branch. Thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-07 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-30 18:45 [PATCH] musb_host: compare status for negative error values Németh Márton
2011-06-07 10:27 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox