From: Ike Panhc <ike.pan@canonical.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH 3/3] ideapad: Show negative when no camera
Date: Thu, 02 Jun 2011 18:17:28 +0800 [thread overview]
Message-ID: <4DE76338.30706@canonical.com> (raw)
In-Reply-To: <BANLkTimfu3pWedHJXtuV-q5risHTyQzNKOaR8P471jmsPfzODg@mail.gmail.com>
On 06/02/2011 05:43 PM, Corentin Chary wrote:
> I think it would be better to not add the file when the camera is not
> available. Another option is to return -ENODEV. But printing -1
> doesn't seems right.
>
Agree, making the node invisible is better.
prev parent reply other threads:[~2011-06-02 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 9:22 [PATCH 1/3] ideapad: Use define for cfg bits Ike Panhc
2011-06-02 9:24 ` [PATCH 2/3] ideapad: Add nodes in sysfs Ike Panhc
2011-06-02 9:48 ` Corentin Chary
2011-06-02 10:14 ` Ike Panhc
2011-06-02 11:22 ` Corentin Chary
2011-06-03 20:21 ` Dmitry Torokhov
2011-06-02 9:24 ` [PATCH 3/3] ideapad: Show negative when no camera Ike Panhc
2011-06-02 9:43 ` Corentin Chary
2011-06-02 10:17 ` Ike Panhc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE76338.30706@canonical.com \
--to=ike.pan@canonical.com \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox