* [PATCH] Use hlist_entry() for io_context.cic_list.first
@ 2011-06-01 19:33 Paul Bolle
2011-06-02 11:05 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2011-06-01 19:33 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel
list_entry() and hlist_entry() are both simply aliases for
container_of(), but since io_context.cic_list.first is an hlist_node one
should at least use the correct alias.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
block/blk-ioc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-ioc.c b/block/blk-ioc.c
index c898049..342eae9 100644
--- a/block/blk-ioc.c
+++ b/block/blk-ioc.c
@@ -21,7 +21,7 @@ static void cfq_dtor(struct io_context *ioc)
if (!hlist_empty(&ioc->cic_list)) {
struct cfq_io_context *cic;
- cic = list_entry(ioc->cic_list.first, struct cfq_io_context,
+ cic = hlist_entry(ioc->cic_list.first, struct cfq_io_context,
cic_list);
cic->dtor(ioc);
}
@@ -57,7 +57,7 @@ static void cfq_exit(struct io_context *ioc)
if (!hlist_empty(&ioc->cic_list)) {
struct cfq_io_context *cic;
- cic = list_entry(ioc->cic_list.first, struct cfq_io_context,
+ cic = hlist_entry(ioc->cic_list.first, struct cfq_io_context,
cic_list);
cic->exit(ioc);
}
--
1.7.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Use hlist_entry() for io_context.cic_list.first
2011-06-01 19:33 [PATCH] Use hlist_entry() for io_context.cic_list.first Paul Bolle
@ 2011-06-02 11:05 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-06-02 11:05 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-kernel
On 2011-06-01 21:33, Paul Bolle wrote:
> list_entry() and hlist_entry() are both simply aliases for
> container_of(), but since io_context.cic_list.first is an hlist_node one
> should at least use the correct alias.
Thanks, that does look cleaner.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-02 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 19:33 [PATCH] Use hlist_entry() for io_context.cic_list.first Paul Bolle
2011-06-02 11:05 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox