public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove bogus check in queue_fail path
@ 2011-06-01 19:34 Paul Bolle
  2011-06-02 11:05 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2011-06-01 19:34 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-kernel

queue_fail can only be reached if cic is NULL, so its check for cic must
be bogus.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 block/cfq-iosched.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 7c52d68..9632e62 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3786,9 +3786,6 @@ new_queue:
 	return 0;
 
 queue_fail:
-	if (cic)
-		put_io_context(cic->ioc);
-
 	cfq_schedule_dispatch(cfqd);
 	spin_unlock_irqrestore(q->queue_lock, flags);
 	cfq_log(cfqd, "set_request fail");
-- 
1.7.5.2




^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-02 11:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 19:34 [PATCH] Remove bogus check in queue_fail path Paul Bolle
2011-06-02 11:05 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox