From: Timur Tabi <timur@freescale.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <alan@lxorguk.ukuu.org.uk>, <linux-kernel@vger.kernel.org>,
<scottwood@freescale.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: introduce strdup_from_user
Date: Fri, 3 Jun 2011 13:54:41 -0500 [thread overview]
Message-ID: <4DE92DF1.4090203@freescale.com> (raw)
In-Reply-To: <BANLkTik_O2QvXqeY03NU3xP1q0=Dqco6Eg@mail.gmail.com>
Alexey Dobriyan wrote:
> It leaks first allocation if second one fails.
>
> Come on.
Ugh, sorry. In my defense, I am suffering from allergies at the moment.
> Show you user in driver, maybe what we're discussing is moot.
The driver and discussion on it can be found here:
http://patchwork.ozlabs.org/patch/98233/
Search for "ioctl_dtprop" to see its usage.
In summary, I'm copying a user-space string into a kmalloc'd buffer so that it's
physically contiguous and I can get the physical address for it. I then call
our hypervisor and give it the physical address. This is why I want a copy of
the string in a buffer allocated via kmalloc.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-06-03 18:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 16:45 [PATCH] lib: introduce strdup_from_user Timur Tabi
2011-06-03 17:45 ` Alexey Dobriyan
2011-06-03 18:22 ` Timur Tabi
2011-06-03 18:26 ` Alexey Dobriyan
2011-06-03 18:34 ` Timur Tabi
2011-06-03 18:39 ` Alexey Dobriyan
2011-06-03 18:41 ` Timur Tabi
2011-06-03 18:47 ` Alexey Dobriyan
2011-06-03 18:54 ` Timur Tabi [this message]
2011-06-03 18:53 ` Scott Wood
2011-06-03 18:57 ` Timur Tabi
2011-06-03 19:12 ` Alexey Dobriyan
2011-06-03 19:31 ` Scott Wood
2011-06-03 22:41 ` Al Viro
2011-06-03 18:37 ` Scott Wood
2011-06-03 21:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE92DF1.4090203@freescale.com \
--to=timur@freescale.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox