Re: Mysterious CFQ crash and RCU

Jens Axboe
2011-05-25T12:51:46Z

On 2011-05-25 14:48, Paul Bolle wrote:
> On Wed, 2011-05-25 at 10:46 +0200, Jens Axboe wrote:
>> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
>> index ab7a9e6..f37e3df 100644
>> --- a/block/cfq-iosched.c
>> +++ b/block/cfq-iosched.c
>> @@ -1827,6 +1827,7 @@ static struct cfq_queue *cfqq_close(struct cfq_data *cfqd,
>> static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd,
>> struct cfq_queue *cur_cfqq)
>> {
>> +#if 0
>> struct cfq_queue *cfqq;
>>
>> if (cfq_class_idle(cur_cfqq))
>> @@ -1870,6 +1871,9 @@ static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd,
>> return NULL;
>>
>> return cfqq;
>> +#else
>> + return cfqq;
>
> This won't compile, obviously. Did you perhaps mean
>
> return NULL;
>
> here?

Eh yes, of course, sorry about that. A bit too quick on the send button.

--
Jens Axboe