From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755109Ab1FFDB7 (ORCPT ); Sun, 5 Jun 2011 23:01:59 -0400 Received: from 0122700014.0.fullrate.dk ([95.166.99.235]:46900 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754316Ab1FFDB5 (ORCPT ); Sun, 5 Jun 2011 23:01:57 -0400 Message-ID: <4DEC431E.2020309@kernel.dk> Date: Mon, 06 Jun 2011 05:01:50 +0200 From: Jens Axboe MIME-Version: 1.0 To: Paul Bolle CC: "Paul E. McKenney" , linux-kernel@vger.kernel.org, Vivek Goyal Subject: Re: [PATCH 2/5] Rename two struct members called "cic_list" References: <1307291188.8545.43.camel@t41.thuisdomein> In-Reply-To: <1307291188.8545.43.camel@t41.thuisdomein> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011-06-05 18:26, Paul Bolle wrote: > Let's call them io_context.cic_hlist and cfq_io_context.cic_node. That > should be much less confusing. > > There's also cfq_data.cic_list. It is allowed to keep its name (as it's > the struct member that's most entitled to that name). I honestly don't see much point to this. It's a list... -- Jens Axboe