From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
WANG Cong <xiyou.wangcong@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Jeff Dike <jdike@addtoit.com>,
Andi Kleen <andi@firstfloor.org>,
Huang Ying <ying.huang@intel.com>, Li Wei <W.Li@Sun.COM>,
Michael Ellerman <michaele@au1.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Heiko Carstens <heicars2@linux.vnet.ibm.com>,
Martin Schwidefsky <mschwid2@linux.vnet.ibm.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL
Date: Mon, 06 Jun 2011 12:56:33 +0200 [thread overview]
Message-ID: <4DECB261.5090109@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110605082100.GA18151@leaf>
On 05.06.2011 10:21, Josh Triplett wrote:
> CONFIG_CONSTRUCTORS controls support for running constructor functions
> at kernel init time. According to commit
> b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
> needs this. However, CONFIG_CONSTRUCTORS currently defaults to y, with
> no option to disable it, and CONFIG_GCOV_KERNEL depends on it. Instead,
> default it to n and have CONFIG_GCOV_KERNEL select it, so that the
> normal case of CONFIG_GCOV_KERNEL=n will result in
> CONFIG_CONSTRUCTORS=n.
>
> Observed in the short list of =y values in a minimal kernel
> configuration.
>
> Signed-off-by: Josh Triplett<josh@joshtriplett.org>
> ---
I tested this patch and GCOV profiling still works with it applied. To
my knowledge, GCOV profiling is the only kernel mechanism using GCC's
constructors and this may save some bytes.
Acked-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Regards,
Peter
next prev parent reply other threads:[~2011-06-06 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 8:21 [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL Josh Triplett
2011-06-06 10:56 ` Peter Oberparleiter [this message]
2011-06-06 22:11 ` Josh Triplett
2011-06-07 2:39 ` Américo Wang
2011-06-06 15:52 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DECB261.5090109@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=W.Li@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=heicars2@linux.vnet.ibm.com \
--cc=jdike@addtoit.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaele@au1.ibm.com \
--cc=mingo@elte.hu \
--cc=mschwid2@linux.vnet.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).