From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754461Ab1FHIfY (ORCPT ); Wed, 8 Jun 2011 04:35:24 -0400 Received: from sm-d311v.smileserver.ne.jp ([203.211.202.206]:10319 "EHLO sm-d311v.smileserver.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904Ab1FHIfV (ORCPT ); Wed, 8 Jun 2011 04:35:21 -0400 Message-ID: <4DEF3447.6050209@dsn.okisemi.com> Date: Wed, 08 Jun 2011 17:35:19 +0900 From: Tomoya MORINAGA User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Tomoya MORINAGA CC: David Brownell , Grant Likely , spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com Subject: Re: [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device ML7213 IOH References: <1307425811-5030-1-git-send-email-tomoya-linux@dsn.okisemi.com> In-Reply-To: <1307425811-5030-1-git-send-email-tomoya-linux@dsn.okisemi.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, Why don't you give us your comment/opinion at all for our v4 patch ?? We have been long waiting since 27-April. (2011/06/07 14:50), Tomoya MORINAGA wrote: > ***Modify Grant's comments. > - Delete unrelated whitespace > - Prevent device driver from accessing platform data > - Add __devinit and __devexit > - Save pdev->dev to pd_dev->dev.parent > - Have own suspend/resume processing in platform_driver. > - Care returned value in pch_spi_init > - Change unregister order > > Support ML7213 device of OKI SEMICONDUCTOR. > ML7213 is companion chip of Intel Atom E6xx series for IVI(In-Vehicle Infotainment). > ML7213 is compatible for Intel EG20T PCH. > > Signed-off-by: Tomoya MORINAGA > --- > drivers/spi/Kconfig | 5 +- > drivers/spi/spi_topcliff_pch.c | 599 +++++++++++++++++++++------------------- > 2 files changed, 317 insertions(+), 287 deletions(-) > -- tomoya OKI SEMICONDUCTOR CO., LTD.