[RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Tomoya MORINAGA]

Hi Grant,

Let me resend again.
I haven't received your answer the following my question yet.

On Friday, May 27, 2011 4:09 PM, Grant Likely wrote:
> Take a look at the new irq_chip_generic infrastructure.  You don't
> need to implement a memory mapped irq controller from scratch anymore.
> Most of the access functions can be taken directly from
> irq_chip_generic instead.

Let me clarify your saying.
  a) We shouldn't use request_irq( ) ?
  b) Does Your  "irq_chip_generic" mean irq_set_handler_data( ) /
irq_set_chained_handler( ) ?
      If yes, Using these functions, I saw IRQ shared other function's
interrupt becomes invalid.

-- 
tomoya
OKI SEMICONDUCTOR CO., LTD.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Grant Likely]

On Tue, Jun 07, 2011 at 03:00:48PM +0900, Tomoya MORINAGA wrote:
> Hi Grant,
> 
> Let me resend again.
> I haven't received your answer the following my question yet.
> 
> On Friday, May 27, 2011 4:09 PM, Grant Likely wrote:
> > Take a look at the new irq_chip_generic infrastructure.  You don't
> > need to implement a memory mapped irq controller from scratch anymore.
> > Most of the access functions can be taken directly from
> > irq_chip_generic instead.
> 
> Let me clarify your saying.
>   a) We shouldn't use request_irq( ) ?
>   b) Does Your  "irq_chip_generic" mean irq_set_handler_data( ) /
> irq_set_chained_handler( ) ?
>       If yes, Using these functions, I saw IRQ shared other function's
> interrupt becomes invalid.
> 

No, I'm saying that you don't need to implement new irq_chip
operations if you use the new irq_chip_generic implementation.

g.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Tomoya MORINAGA]

(2011/06/08 2:22), Grant Likely wrote:
> No, I'm saying that you don't need to implement new irq_chip
> operations if you use the new irq_chip_generic implementation.

I understand your saying. It seems "new irq_chip_generic" was 
implemented in linux-3.0.
However "irq_chip_generic" is not implemented in stable kernel version. 
Right ?
So, first of all, could you accept this patch ?
After the kernel version becomes stable, I will resubmit a patch for 
"new irq_chip_generic".

-- 
tomoya
OKI SEMICONDUCTOR CO., LTD.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Grant Likely]

On Wed, Jun 08, 2011 at 11:29:53AM +0900, Tomoya MORINAGA wrote:
> (2011/06/08 2:22), Grant Likely wrote:
> >No, I'm saying that you don't need to implement new irq_chip
> >operations if you use the new irq_chip_generic implementation.
> 
> I understand your saying. It seems "new irq_chip_generic" was
> implemented in linux-3.0.
> However "irq_chip_generic" is not implemented in stable kernel
> version. Right ?
> So, first of all, could you accept this patch ?
> After the kernel version becomes stable, I will resubmit a patch for
> "new irq_chip_generic".

Ah, I understand what you're asking.

Sorry, but I cannot pickup this patch for the stable series.  It is a
new feature, not a bug fix.  Only bug fixes should be going into the
stable kernel series.

g.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Tomoya MORINAGA]

(2011/06/08 23:57), Grant Likely wrote:
> Ah, I understand what you're asking.
>
> Sorry, but I cannot pickup this patch for the stable series.  It is a
> new feature, not a bug fix.  Only bug fixes should be going into the
> stable kernel series.
>

My request didn't mean like above.
I meant that I want you to add the patch to next version linux, namely "3.1"
Because "irq_chip_generic" is implemented only RC version, namely "3.0-rcX"

Anyway, I don't think you change your opinion.
Thus, I must re-coding using "irq_chip_generic".

Thanks,
-- 
tomoya
OKI SEMICONDUCTOR CO., LTD.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Tomoya MORINAGA]

Hi Grant

(2011/06/08 2:22), Grant Likely wrote:
>
> You don't need to implement new irq_chip
> operations if you use the new irq_chip_generic implementation.
>

I have recently started implementing GPIO interrupt using irq_chip_generic.
However, the compile becomes failed.
   irq_alloc_generic_chip: undefined reference
   irq_setup_generic_chip: undefined reference

It seems irq_chip_generic is only ARM code.(linux-3.0-rc3)
Does X86 support irq_chip_generic ?


-- 
tomoya
OKI SEMICONDUCTOR CO., LTD.

Re: [RESEND]: RE: [PATCH v2 3/3] pch_gpio: support interrupt function

[Grant Likely]

On Sun, Jun 19, 2011 at 7:07 PM, Tomoya MORINAGA
<tomoya-linux@dsn.okisemi.com> wrote:
> Hi Grant
>
> (2011/06/08 2:22), Grant Likely wrote:
>>
>> You don't need to implement new irq_chip
>> operations if you use the new irq_chip_generic implementation.
>>
>
> I have recently started implementing GPIO interrupt using irq_chip_generic.
> However, the compile becomes failed.
>  irq_alloc_generic_chip: undefined reference
>  irq_setup_generic_chip: undefined reference
>
> It seems irq_chip_generic is only ARM code.(linux-3.0-rc3)
> Does X86 support irq_chip_generic ?

Make sure your driver has "select GENERIC_IRQ_CHIP" in the Kconfig entry.

g.