From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757419Ab1FIMAP (ORCPT ); Thu, 9 Jun 2011 08:00:15 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:36397 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754443Ab1FIMAL (ORCPT ); Thu, 9 Jun 2011 08:00:11 -0400 Message-ID: <4DF0B5C2.6030500@mev.co.uk> Date: Thu, 9 Jun 2011 13:00:02 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110526 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: "Prashant P. Shah" CC: "devel@linuxdriverproject.org" , Greg Kroah-Hartman , Frank Mori Hess , Ian Abbott , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Staging: comedi: dyna_pci10xx: replace semaphore with mutex References: <20110609115215.GA14569@mail.fossee.in> In-Reply-To: <20110609115215.GA14569@mail.fossee.in> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/11 12:52, Prashant P. Shah wrote: > - sema_init(&devpriv->sem, 1); > + mutex_init(&devpriv->mutex); > dev->board_ptr = &boardtypes[board_index]; > devpriv->pci_dev = pcidev; You could call mutex_destroy() in your _detach routine as well. It's used for debugging mutexes: static int dyna_pci10xx_detach(struct comedi_device *dev) { if (devpriv && devpriv->pci_dev) { comedi_pci_disable(devpriv->pci_dev); mutex_destroy(&devpriv->mutex); } return 0; } -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-