From: Jonathan Cameron <jic23@cam.ac.uk>
To: anish singh <anish198519851985@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>, Ben Dooks <ben-i2c@fluff.org>,
gregkh@suse.de, manuel.stahl@iis.fraunhofer.de,
lucas.demarchi@profusion.mobi, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] staging iio: Replace kmalloc with local variable
Date: Thu, 09 Jun 2011 15:51:06 +0100 [thread overview]
Message-ID: <4DF0DDDA.40105@cam.ac.uk> (raw)
In-Reply-To: <BANLkTik4Tfd73iKcDsXK-sfy6_ADVX4oYA@mail.gmail.com>
On 06/09/11 15:29, anish singh wrote:
>
>
> On Thu, Jun 9, 2011 at 7:46 PM, Jonathan Cameron <jic23@cam.ac.uk <mailto:jic23@cam.ac.uk>> wrote:
>
> On 06/09/11 09:48, Jonathan Cameron wrote:
> > On 06/09/11 09:34, anish singh wrote:
> >>
> >>
> >> On Thu, Jun 9, 2011 at 1:59 PM, Jean Delvare <khali@linux-fr.org <mailto:khali@linux-fr.org> <mailto:khali@linux-fr.org <mailto:khali@linux-fr.org>>> wrote:
> >>
> >> On Thu, 9 Jun 2011 13:53:09 +0530, anish singh wrote:
> >> > On Wed, Jun 8, 2011 at 10:41 AM, anish singh <anish198519851985@gmail.com <mailto:anish198519851985@gmail.com> <mailto:anish198519851985@gmail.com <mailto:anish198519851985@gmail.com>>>wrote:
> >> > > On Tue, Jun 7, 2011 at 7:32 PM, Jean Delvare <khali@linux-fr.org <mailto:khali@linux-fr.org> <mailto:khali@linux-fr.org <mailto:khali@linux-fr.org>>> wrote:
> >> > >> To be clearer, it is down to the i2c BUS (adapter) driver, NOT the i2c
> >> > >> device driver. So the patch is correct.
> >> > >>
> >> > > I think i can take Jean ack on this?If yes then Joanthan kindly apply
> >> > > this patch and i think you didn't lead me in wrong way as whatever
> >> > > said by you is corroborated by jean also i.e. it is I2C bus driver
> >> > > responsiblity
> >> > > to care about DMA.
> >> > >
> >> > Sorry to ping you again.Can i take your ack on this?
> >>
> >> Yes of course.
> >>
> >> Acked-by: Jean Delvare <khali@linux-fr.org <mailto:khali@linux-fr.org> <mailto:khali@linux-fr.org <mailto:khali@linux-fr.org>>>
> >>
> >> Thanks a ton.Jonathan kindly apply it now :)
> > Greg, I'll send this one on to you with the set I currently have out for review.
> >
> Doh, after all this, I just tried to apply this to find the code in question has already
> gone. Anish, what tree are you working against?
>
> I am using linux-next.Is it not the right tree for staging?
Something curious is going on then because this code is no longer in linux-next either.
>
> Looks like I did an equivalent clean up
> (with a load of others) back in May then forgot about it.
>
> Sorry all. I should have actually have checked it was still relevant rather than reviewing
> purely on basis of content of patch...
>
> Jonathan
>
>
prev parent reply other threads:[~2011-06-09 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 12:39 [PATCH] staging iio: Replace kmalloc with local variable anish
2011-06-07 13:00 ` Jonathan Cameron
2011-06-07 13:41 ` Ben Dooks
2011-06-07 13:54 ` Jonathan Cameron
2011-06-07 14:04 ` Hennerich, Michael
2011-06-07 14:02 ` Jean Delvare
[not found] ` <BANLkTim5-ZKXtDkSQyHAJ9-iKtOPsJ917A@mail.gmail.com>
[not found] ` <BANLkTi=e0A2G-d+t4VF5V0gj+eNoh3KRnQ@mail.gmail.com>
2011-06-09 8:29 ` Jean Delvare
[not found] ` <BANLkTimq_5rmB+UkaxZwrOtV-ZF3+fEOgQ@mail.gmail.com>
2011-06-09 8:48 ` Jonathan Cameron
2011-06-09 10:46 ` Jonathan Cameron
[not found] ` <BANLkTik4Tfd73iKcDsXK-sfy6_ADVX4oYA@mail.gmail.com>
2011-06-09 14:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0DDDA.40105@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=anish198519851985@gmail.com \
--cc=ben-i2c@fluff.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=manuel.stahl@iis.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox