public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Witold Szczeponik <Witold.Szczeponik@gmx.net>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: 'flags' in rsparser.c change from 'register disabled resources' patch
Date: Thu, 09 Jun 2011 20:58:00 +0200	[thread overview]
Message-ID: <4DF117B8.8080408@gmx.net> (raw)
In-Reply-To: <20110822005902.GA30602@gallifrey>

Hi David,

your observation is correct.  In fact, the patch can be simplified by 
not setting the IORESOURCE_DISABLED flag at all, which is functionally 
equivalent to the current state where the compiler removes this value 
because it cannot be assigned to a char.  A quick compare of the 
generated code of the current version (with  IORESOURCE_DISABLED 
included) and with IORESOURCE_DISABLED not used at all yields pretty 
much the same code.

I realized the problem only days after I submitted my patch. 
Apparently, a follow-up patch which takes care of the 
IORESOURCE_DISABLED flags did not make it into the mainline kernel. 
I'll resend it as a response to this post shortly.  In addition, in 
https://lkml.org/lkml/2011/7/31/50 I submitted a much simpler version of 
the patch which better exposes the change it introduces but requires 
29df8d8f8702f0f53c1375015f09f04bc8d023c1 to be reverted.

--- Witold

  reply	other threads:[~2011-09-06 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22  0:59 'flags' in rsparser.c change from 'register disabled resources' patch Dr. David Alan Gilbert
2011-06-09 18:58 ` Witold Szczeponik [this message]
2011-06-09 19:03   ` [PATCH] PNPACPI: Simplify disabled resource registration Witold Szczeponik
2011-09-13 16:25     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF117B8.8080408@gmx.net \
    --to=witold.szczeponik@gmx.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@treblig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox