From: Chris Metcalf <cmetcalf@tilera.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
<lethal@linux-sh.org>, <davem@davemloft.net>,
<tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<damm@opensource.se>, <arnd@arndb.de>, <hans.rosenfeld@amd.com>,
<len.brown@intel.com>, <borislav.petkov@amd.com>, <tj@kernel.org>
Subject: Re: [PATCH v3] cpuinfo_op: consolidate extern declaration
Date: Fri, 10 Jun 2011 10:18:55 -0400 [thread overview]
Message-ID: <4DF227CF.4080807@tilera.com> (raw)
In-Reply-To: <201106081559.42931.hartleys@visionengravers.com>
On 6/8/2011 6:59 PM, H Hartley Sweeten wrote:
> All the architectures supported by the kernel also support
> /proc/cpuinfo. Only a couple actually declare the seq_operations
> as extern. All the others will produce a sparse warning like:
>
> warning: symbol 'cpuinfo_op' was not declared. Should it be static?
>
> Fix all the warnings and consolidate the declaration by putting it
> in <linux/seq_file.h>.
>
> [...]
> --- a/arch/tile/include/asm/processor.h
> +++ b/arch/tile/include/asm/processor.h
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2011-06-10 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 22:59 [PATCH v3] cpuinfo_op: consolidate extern declaration H Hartley Sweeten
2011-06-10 14:18 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF227CF.4080807@tilera.com \
--to=cmetcalf@tilera.com \
--cc=arnd@arndb.de \
--cc=borislav.petkov@amd.com \
--cc=damm@opensource.se \
--cc=davem@davemloft.net \
--cc=hans.rosenfeld@amd.com \
--cc=hartleys@visionengravers.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox