From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org, Mike Frysinger <vapier@gentoo.org>,
linux-kernel@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver
Date: Fri, 10 Jun 2011 20:13:03 +0200 [thread overview]
Message-ID: <4DF25EAF.7050203@metafoo.de> (raw)
In-Reply-To: <20110610180256.GQ26436@opensource.wolfsonmicro.com>
On 06/10/2011 08:02 PM, Mark Brown wrote:
> On Fri, Jun 10, 2011 at 07:50:17PM +0200, Lars-Peter Clausen wrote:
>> On 06/10/2011 07:30 PM, Mark Brown wrote:
>
>>> So, I keep on complaining about the way these drivers are just generic
>>> to any random Blackfin plus CODEC combination rather than being board
>>> specific. It'd be good if we could improve this, even adding something
>>> into the driver name to make it clear these are for the EVB would help.
>
>> I think this is due, that the codecs them-self sit on an add-on board to the
>> bf5xx eval boards.
>> So you have two boards, the bf5xx eval board with has the codec eval board
>> connected to it. That's why it it is kept so generic. You could connect the
>> codec eval board to any of the bf5xx boards.
>
> I'd be more happy with that if there were some indication in the code
> that this was for the standard Blackfin EVBs rather than all systems
> based on Blackfin.
I could rename the machine driver to bf5xx-adau1701-evb for v2.
- Lars
next prev parent reply other threads:[~2011-06-10 18:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 17:18 [PATCH 1/3] ASoC: Add ADAU1701 codec driver Lars-Peter Clausen
2011-06-10 17:18 ` [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver Lars-Peter Clausen
2011-06-10 17:30 ` [alsa-devel] " Mark Brown
2011-06-10 17:47 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 18:01 ` Mark Brown
2011-06-10 18:13 ` Mike Frysinger
2011-06-10 18:15 ` Mark Brown
2011-06-10 17:50 ` Lars-Peter Clausen
2011-06-10 18:02 ` Mark Brown
2011-06-10 18:13 ` Lars-Peter Clausen [this message]
2011-06-10 18:20 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:18 ` [PATCH 3/3] Blackfin: bf537: Stamp: Register adau1701 codec and ASoC " Lars-Peter Clausen
2011-06-10 17:50 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:27 ` [alsa-devel] [PATCH 1/3] ASoC: Add ADAU1701 codec driver Mark Brown
2011-06-10 17:44 ` Mike Frysinger
2011-06-10 18:07 ` Mark Brown
2011-06-10 18:08 ` Mike Frysinger
2011-06-10 17:43 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:57 ` Lars-Peter Clausen
2011-06-10 18:08 ` Mike Frysinger
2011-06-10 18:15 ` Mike Frysinger
2011-06-10 18:22 ` Lars-Peter Clausen
2011-06-10 18:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF25EAF.7050203@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox