Re: [Xen-devel] [PATCH 1/2] xen: Add __attribute__((format(printf... where appropriate

Joe Perches
2011-06-13T16:40:53Z

On Mon, 2011-06-13 at 12:31 -0400, Konrad Rzeszutek Wilk wrote:
> On Sun, Jun 12, 2011 at 09:21:13AM -0700, Joe Perches wrote:
> > Use the compiler to verify printf formats and arguments.
> What compiler?

Any supported version of gcc.

> If this is not included in 3.0 what is the fallout?

Nothing of any import.
nodename won't get printed on an unlikely error message.
I don't think it should go into 3.0.

> > err = xenbus_switch_state(dev, XenbusStateConnected);
> > if (err)
> > - xenbus_dev_fatal(dev, err, "switching to Connected state",
> > + xenbus_dev_fatal(dev, err, "%s: switching to Connected state",
> > dev->nodename);