From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Cc: debora@linux.vnet.ibm.com, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, jirislaby@gmail.com,
preining@logic.at
Subject: Re: [PATCH V2 00/12] tpm + tpm_tis : Various fixes
Date: Mon, 13 Jun 2011 11:34:23 -0400 [thread overview]
Message-ID: <4DF62DFF.8050105@linux.vnet.ibm.com> (raw)
In-Reply-To: <4DE4EBE0.7050007@linux.vnet.ibm.com>
On 05/31/2011 09:23 AM, Rajiv Andrade wrote:
> Hi Stefan,
>
> Yes, I'll have them reviewed again and in a git pull request real soon.
Has the review-oracle spoken in the meantime ? What did it say?
Stefan
> Thanks, Rajiv Andrade
> Security Development
> IBM Linux Technology Center
>
> On 05/27/2011 05:55 PM, Stefan Berger wrote:
>> Rajiv,
>>
>> are you planning to use these patches?
>>
>> Regards,
>> Stefan
>>
>>
>> On 03/30/2011 12:13 PM, Stefan Berger wrote:
>>> This patchset fixes various issues in the general TPM driver and the TPM TIS
>>> driver. Some of the patches were previously posted, and are being re-posted
>>> without change, while other patches were refactored. This patchset applies to
>>> the tip of the main git tree.
>>>
>>> Patches 1-6 are related to using the timeouts that the TPM reports, along with
>>> work-arounds for TPMs that don't report the timeouts in microseconds but
>>> rather in milliseconds.
>>>
>>> Patch 7 fixes the display of the public key of the TPM's Endorsement Key in
>>> sysfs.
>>>
>>> Patch 8 re-enables the TPM's interrupts after resume from S3.
>>>
>>> Patch 9 is useful if the TPM is run in interrupt mode and delays the S3 suspend
>>> until the TPM has finished processing a command.
>>>
>>> Patch 10 fixes several aspects of the code around the probing for interrupts.
>>>
>>> Patch 11 introduces automatic probing for the Intel iTPM flaw. The probing
>>> is useful in combination with the 'force' module parameter that enables
>>> the interrupt mode on some machines but then ends up circumventing ACPI to
>>> determine whether an Intel iTPM is present to activate the work-around. So,
>>> in that case we can rely on the probing.
>>>
>>> Patch 12 fixes a typo.
>>>
>>> I have tested these patches on four different types of machines. They worked
>>> fine there even though the TPM could not be used in interrupt mode on all of
>>> them (IRQ line not connected?).
>>>
>>> V2:
>>> - following Rajiv's feedback. Splitting the durations and timeout
>>> patches in 3 parts.
>>> - slightly rearranging the order of the patches
>>>
>>> Regards,
>>> Stefan
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>> Please read the FAQ at http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-06-13 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 16:13 [PATCH V2 00/12] tpm + tpm_tis : Various fixes Stefan Berger
2011-03-30 16:13 ` [PATCH V2 01/12] tpm: Use durations returned from TPM Stefan Berger
2011-03-30 16:13 ` [PATCH V2 02/12] tpm: Adjust the durations if they are too small Stefan Berger
2011-03-30 16:13 ` [PATCH V2 03/12] tpm_tis: Introduce durations sysfs entry Stefan Berger
2011-03-30 16:13 ` [PATCH V2 04/12] tpm: Use interface timeouts returned from the TPM Stefan Berger
2011-03-30 16:13 ` [PATCH V2 05/12] tpm: Adjust interface timeouts if they are too small Stefan Berger
2011-03-30 16:13 ` [PATCH V2 06/12] tpm_tis: Add timeouts sysfs entry Stefan Berger
2011-03-30 16:13 ` [PATCH V2 07/12] tpm: Fix display of data in pubek " Stefan Berger
2011-03-30 16:13 ` [PATCH V2 08/12] tpm_tis: Re-enable interrupts upon (S3) resume Stefan Berger
2011-03-30 16:13 ` [PATCH V2 09/12] tpm_tis: Delay ACPI S3 suspend while the TPM is busy Stefan Berger
2011-03-30 16:13 ` [PATCH V2 10/12] tpm_tis: Fix the probing for interrupts Stefan Berger
2011-03-30 16:13 ` [PATCH V2 11/12] tpm_tis: Probing function for Intel iTPM bug Stefan Berger
2011-03-30 16:13 ` [PATCH V2 12/12] tpm: Fix a typo Stefan Berger
2011-05-27 20:55 ` [PATCH V2 00/12] tpm + tpm_tis : Various fixes Stefan Berger
2011-05-31 13:23 ` Rajiv Andrade
2011-06-13 15:34 ` Stefan Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF62DFF.8050105@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=debora@linux.vnet.ibm.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=preining@logic.at \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox