public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [3.0-rc3] scripts/depmod.sh: Permission denied
@ 2011-06-14  0:41 Tetsuo Handa
  2011-06-14  5:14 ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Tetsuo Handa @ 2011-06-14  0:41 UTC (permalink / raw)
  To: mmarek; +Cc: linux-kernel

linux-3.0-rc3.tar.bz2 generates
-rwxrwxr-x  1 root root 1231 Jun 14 07:29 linux-3.0-rc3/scripts/depmod.sh
but linux-2.6.39.tar.bz2 + patch-3.0-rc3.bz2 generates
-rw-r--r--  1 root root 1231 Jun 14 09:34 scripts/depmod.sh
which results in

make: execvp: /usr/src/linux-3.0-rc3/scripts/depmod.sh: Permission denied
make: *** [_modinst_post] Error 127

Would you add "chmod +x scripts/depmod.sh" before invoking depmod.sh ?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [3.0-rc3] scripts/depmod.sh: Permission denied
  2011-06-14  0:41 [3.0-rc3] scripts/depmod.sh: Permission denied Tetsuo Handa
@ 2011-06-14  5:14 ` Michal Marek
  2011-06-15 20:31   ` [PATCH] kbuild: Call depmod.sh via shell Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2011-06-14  5:14 UTC (permalink / raw)
  To: Tetsuo Handa; +Cc: linux-kernel

Dne 14.6.2011 02:41, Tetsuo Handa napsal(a):
> linux-3.0-rc3.tar.bz2 generates
> -rwxrwxr-x  1 root root 1231 Jun 14 07:29 linux-3.0-rc3/scripts/depmod.sh
> but linux-2.6.39.tar.bz2 + patch-3.0-rc3.bz2 generates
> -rw-r--r--  1 root root 1231 Jun 14 09:34 scripts/depmod.sh
> which results in

Ah, I forgot about patch(1) users.


> make: execvp: /usr/src/linux-3.0-rc3/scripts/depmod.sh: Permission denied
> make: *** [_modinst_post] Error 127
> 
> Would you add "chmod +x scripts/depmod.sh" before invoking depmod.sh ?

I'll change the call to $(CONFIG_SHELL) $(scrtree)/scripts/depmod.sh
instead.

Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] kbuild: Call depmod.sh via shell
  2011-06-14  5:14 ` Michal Marek
@ 2011-06-15 20:31   ` Michal Marek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2011-06-15 20:31 UTC (permalink / raw)
  To: Tetsuo Handa; +Cc: linux-kernel

The script has the executable bit in git, but plain old patch(1) can't
create executable files.

Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 4350937..6764063 100644
--- a/Makefile
+++ b/Makefile
@@ -1526,7 +1526,8 @@ quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files))
 
 # Run depmod only if we have System.map and depmod is executable
 quiet_cmd_depmod = DEPMOD  $(KERNELRELEASE)
-      cmd_depmod = $(srctree)/scripts/depmod.sh $(DEPMOD) $(KERNELRELEASE)
+      cmd_depmod = $(CONFIG_SHELL) $(srctree)/scripts/depmod.sh $(DEPMOD) \
+                   $(KERNELRELEASE)
 
 # Create temporary dir for module support files
 # clean it up only when building all modules
-- 
1.7.4.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-15 20:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-14  0:41 [3.0-rc3] scripts/depmod.sh: Permission denied Tetsuo Handa
2011-06-14  5:14 ` Michal Marek
2011-06-15 20:31   ` [PATCH] kbuild: Call depmod.sh via shell Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox