* [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
@ 2011-06-13 21:21 Денис Кузьменко
2011-06-14 10:51 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Денис Кузьменко @ 2011-06-13 21:21 UTC (permalink / raw)
To: Ben Dooks, Russell King, linux-arm-kernel, linux-kernel
Cc: Денис Кузьменко
From: Denis Kuzmenko <dart@solonet.org.ua>
LCD-W35i support for Mini2440 development board
--- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c
2011-06-03 03:34:20.000000000 +0300
+++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c
2011-06-13 23:37:38.785984118 +0300
@@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
.lcdcon5 = (S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_HWSWP),
},
+ /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
+ [3] = {
+ _LCD_DECLARE(
+ 7, /* clock */
+ 320, 68, 66, 4, /* xres, margin_right,
margin_left, hsync */
+ 240, 4, 4, 9, /* yres, margin_top,
margin_bottom, vsync */
+ 60), /* refresh rate */
+ .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
+ S3C2410_LCDCON5_INVVDEN |
+ S3C2410_LCDCON5_INVVFRAME |
+ S3C2410_LCDCON5_INVVLINE |
+ S3C2410_LCDCON5_INVVCLK |
+ S3C2410_LCDCON5_HWSWP),
+ },
};
/* todo - put into gpio header */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
2011-06-13 21:21 [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support Денис Кузьменко
@ 2011-06-14 10:51 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2011-06-14 10:51 UTC (permalink / raw)
To: Денис Кузьменко
Cc: Ben Dooks, Russell King, linux-arm-kernel, linux-kernel
Hello.
On 14-06-2011 1:21, Денис Кузьменко wrote:
> From: Denis Kuzmenko <dart@solonet.org.ua>
Need an empty line here...
> LCD-W35i support for Mini2440 development board
> --- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c
> 2011-06-03 03:34:20.000000000 +0300
> +++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c
> 2011-06-13 23:37:38.785984118 +0300
> @@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
> .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
> S3C2410_LCDCON5_HWSWP),
> },
> + /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
> + [3] = {
> + _LCD_DECLARE(
> + 7, /* clock */
> + 320, 68, 66, 4, /* xres, margin_right,
> margin_left, hsync */
> + 240, 4, 4, 9, /* yres, margin_top,
> margin_bottom, vsync */
Your patch is line wrapped. Seems easy to fix though...
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
@ 2011-06-14 20:31 Denis Kuzmenko
2011-06-16 11:34 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Denis Kuzmenko @ 2011-06-14 20:31 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ben Dooks, Russell King, linux-arm-kernel, linux-kernel
2011/6/14 Sergei Shtylyov <sshtylyov@mvista.com>
> Need an empty line here...
> Your patch is line wrapped. Seems easy to fix though...
Thank you. Is the patch below okay?
From: Denis Kuzmenko <dart@solonet.org.ua>
LCD-W35i support for Mini2440 development board
--- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c
2011-06-03 03:34:20.000000000 +0300
+++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c
2011-06-13 23:37:38.785984118 +0300
@@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
.lcdcon5 = (S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_HWSWP),
},
+ /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
+ [3] = {
+ _LCD_DECLARE(
+ 7, /* clock */
+ 320, 68, 66, 4, /* xres, margin_right,
margin_left, hsync */
+ 240, 4, 4, 9, /* yres, margin_top,
margin_bottom, vsync */
+ 60), /* refresh rate */
+ .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
+ S3C2410_LCDCON5_INVVDEN |
+ S3C2410_LCDCON5_INVVFRAME |
+ S3C2410_LCDCON5_INVVLINE |
+ S3C2410_LCDCON5_INVVCLK |
+ S3C2410_LCDCON5_HWSWP),
+ },
};
/* todo - put into gpio header */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
2011-06-14 20:31 Denis Kuzmenko
@ 2011-06-16 11:34 ` Sergei Shtylyov
2011-06-16 18:35 ` Denis Kuzmenko
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2011-06-16 11:34 UTC (permalink / raw)
To: Denis Kuzmenko
Cc: Sergei Shtylyov, Ben Dooks, Russell King, linux-arm-kernel,
linux-kernel
Hello.
On 15-06-2011 0:31, Denis Kuzmenko wrote:
>> Need an empty line here...
>> Your patch is line wrapped. Seems easy to fix though...
> Thank you. Is the patch below okay?
Not yet. :-)
> From: Denis Kuzmenko <dart@solonet.org.ua>
> LCD-W35i support for Mini2440 development board
Your signoff needs to be here. Sorry -- didn't notice the first time.
> --- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-03
> 03:34:20.000000000 +0300
> +++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-13
> 23:37:38.785984118 +0300
> @@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
> .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
> S3C2410_LCDCON5_HWSWP),
> },
> + /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
> + [3] = {
> + _LCD_DECLARE(
> + 7, /* clock */
> + 320, 68, 66, 4, /* xres, margin_right, margin_left, hsync */
> + 240, 4, 4, 9, /* yres, margin_top, margin_bottom, vsync */
> + 60), /* refresh rate */
> + .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
> + S3C2410_LCDCON5_INVVDEN |
> + S3C2410_LCDCON5_INVVFRAME |
> + S3C2410_LCDCON5_INVVLINE |
> + S3C2410_LCDCON5_INVVCLK |
> + S3C2410_LCDCON5_HWSWP),
> + },
> };
The patch has all tabs converted to spaces. Didn't notice it the first
time as well... :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
2011-06-16 11:34 ` Sergei Shtylyov
@ 2011-06-16 18:35 ` Denis Kuzmenko
2011-06-17 11:42 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Denis Kuzmenko @ 2011-06-16 18:35 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ben Dooks, Russell King, linux-arm-kernel, linux-kernel
On 06/16/2011 02:34 PM, Sergei Shtylyov wrote:
> Hello.
> Your signoff needs to be here. Sorry -- didn't notice the first time.
> The patch has all tabs converted to spaces. Didn't notice it the first
> time as well... :-/
Thanks for comments. How about this one?
From: Denis Kuzmenko <dart@solonet.org.ua>
Date: 2011-06-16 21:30:00 +0300
LCD-W35i support for Mini2440 development board
Signed-off-by: Denis Kuzmenko <dart@solonet.org.ua>
--- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-03
03:34:20.000000000 +0300
+++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-13
23:37:38.785984118 +0300
@@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
.lcdcon5 = (S3C2410_LCDCON5_FRM565 |
S3C2410_LCDCON5_HWSWP),
},
+ /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
+ [3] = {
+ _LCD_DECLARE(
+ 7, /* clock */
+ 320, 68, 66, 4, /* xres, margin_right, margin_left, hsync */
+ 240, 4, 4, 9, /* yres, margin_top, margin_bottom, vsync */
+ 60), /* refresh rate */
+ .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
+ S3C2410_LCDCON5_INVVDEN |
+ S3C2410_LCDCON5_INVVFRAME |
+ S3C2410_LCDCON5_INVVLINE |
+ S3C2410_LCDCON5_INVVCLK |
+ S3C2410_LCDCON5_HWSWP),
+ },
};
/* todo - put into gpio header */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
2011-06-16 18:35 ` Denis Kuzmenko
@ 2011-06-17 11:42 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2011-06-17 11:42 UTC (permalink / raw)
To: Denis Kuzmenko
Cc: Sergei Shtylyov, Ben Dooks, Russell King, linux-arm-kernel,
linux-kernel
Hello.
On 16-06-2011 22:35, Denis Kuzmenko wrote:
>> Hello.
>> Your signoff needs to be here. Sorry -- didn't notice the first time.
>> The patch has all tabs converted to spaces. Didn't notice it the first
>> time as well... :-/
> Thanks for comments. How about this one?
Seems fine now. :-)
> From: Denis Kuzmenko <dart@solonet.org.ua>
> Date: 2011-06-16 21:30:00 +0300
> LCD-W35i support for Mini2440 development board
> Signed-off-by: Denis Kuzmenko <dart@solonet.org.ua>
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-17 11:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 21:21 [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support Денис Кузьменко
2011-06-14 10:51 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2011-06-14 20:31 Denis Kuzmenko
2011-06-16 11:34 ` Sergei Shtylyov
2011-06-16 18:35 ` Denis Kuzmenko
2011-06-17 11:42 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox