Re: [PATCH v2] x86, efi: Do not reserve boot services regions within reserved areas

[Maarten Lankhorst <m.b.lankhorst@gmail.com>]

Op 14-06-11 19:05, Joe Perches schreef:
> On Tue, 2011-06-14 at 18:19 +0200, Maarten Lankhorst wrote:
>> Commit 916f676f8dc started reserving boot service code since some systems
>> require you to keep that code around until SetVirtualAddressMap is called.
> []
>> Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>
> Hello Maarten, just trivia.
>
>> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> []
>> +			memblock_dbg(PFX "Could not reserve boot area "
>> +				"[0x%llx-0x%llx)\n", start, start+size);
> I believe this should be:
>
> 			memblock_dbg(PFX "Could not reserve boot area 0x%llx-0x%llx)\n",
> 				     start, start + size - 1);
Erm, no. [x...y) means the range of x to y without including y.

Other efi code followed that convention, and the e820 code does the same, silently.

[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 00000000000a0000 (usable)
...
[    0.000000] EFI: mem00: type=3, attr=0xf, range=[0x0000000000000000-0x0000000000008000) (0MB)

~Maarten