RE: [PATCH] [SCSI] LIBSAS: fix libsas link error issue

Jack Wang
2011-06-16T06:55:35Z

> > >[Jack Wang]
> > >I don't think the statement below is error:
> > >child->linkrate = min(parent_phy->linkrate, child->max_linkrate);
>
> The parent_phy is same to child_phy, I don't think it's right.
>
[Jack Wang] The parent_phy->linkrate is report from DISCOVER response as
negotiated link rate(parent phy with child phy), so same is right.

> >> Yes, you can test like this.
> >> >Then expander1's linkrate will set to 3G, and expander2's linkrate
will
> set
> >> >to 6G, that is correct.
> >> yes
> >> > But the connection rate will be 3G from hba to
> >> >expander2.
> >> How to configure the connection rate?
> >> Now, MVSAS driver get 6G from sas_ex_get_linkrate function, and set
> linkrate
> >> of OPEN address frame to the value. right?
> >>
> >> --
> >[Jack Wang]
> >Connection rate is auto, link layer will insert deletable primitives to
do
> >rate matching (sas2r15 7.14).
>
> >Yes, you should set the linkrate to that value .
>
> OK.MVSAS driver seem right. But, the problem is command fail because of
link
> error, that is why I commit this patch. And my patch work fine.
> You can reproduce the issue and fix it. Thanks!
[Jack Wang] I re-consider it , you maybe should compare the HBA linkrate
with the child phy linkrate and chose a minor.

I