Re: [PATCH v4 3.0-rc2-tip 20/22] 20: perf: perf interface for uprobes

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2011/06/14 20:56), Srikar Dronamraju wrote:
>>>> I think -u option should have a path of the target binary, as below
>>>>
>>>> # perf probe -u /bin/zsh -a zfree
>>>
>>> Will --uprobe work as the long name option for -u or do you suggest
>>> something else?
>>
>> Hmm, good question. Maybe we can use -x|--exec to define a uprobe event,
>> because there is no need to give an executable file for kprobes events.
>> # so that -x implies user space event on given execfile
>>
> 
> Okay, then lets stick with perf probe -x executable <function-name>
> then.

Thanks:-)

>> However, Maybe we'd better look this more carefully. Here, we have
>> a problem with listing userspace probes (I mean how perf probe can
>> list up the probes which is on a user app)
>>
>> Currently, it just ignores module name if a probe on a module.
>>   probe:fuse_do_open   (on fuse_do_open@ksrc/linux-2.6/fs/fuse/file.c with isdir)
>>
>> One possible solution is to show the module name right before the
>> symbol as same as the kernel does.
>>
>>   probe:fuse_do_open   (on fuse:fuse_do_open@ksrc/linux-2.6/fs/fuse/file.c with
>> isdir)
> 
> This looks better to me.

OK, this will be good for starting point. If someone complains,
we can switch to below format.

>> Another way is to show it more verbosely, like below.
>>
>>   probe:fuse_do_open   (at fuse_do_open@ksrc/linux-2.6/fs/fuse/file.c with isdir
>> on fuse)
>>   probe_zsh:zfree      (at 0x45400 on /bin/zsh)
>>
> 
> But I am okay with changing to this format too.
> 

Thanks!

-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com