From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Denis Kuzmenko <list@solonet.org.ua>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Ben Dooks <ben-linux@fluff.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support
Date: Thu, 16 Jun 2011 15:34:29 +0400 [thread overview]
Message-ID: <4DF9EA45.3020101@ru.mvista.com> (raw)
In-Reply-To: <4DF7C50A.7060602@solonet.org.ua>
Hello.
On 15-06-2011 0:31, Denis Kuzmenko wrote:
>> Need an empty line here...
>> Your patch is line wrapped. Seems easy to fix though...
> Thank you. Is the patch below okay?
Not yet. :-)
> From: Denis Kuzmenko <dart@solonet.org.ua>
> LCD-W35i support for Mini2440 development board
Your signoff needs to be here. Sorry -- didn't notice the first time.
> --- linux-2.6.39.1/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-03
> 03:34:20.000000000 +0300
> +++ linux-2.6.39.1-dart/arch/arm/mach-s3c2440/mach-mini2440.c 2011-06-13
> 23:37:38.785984118 +0300
> @@ -167,6 +167,20 @@ static struct s3c2410fb_display mini2440
> .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
> S3C2410_LCDCON5_HWSWP),
> },
> + /* LCD-W35i 3.5" display (LQ035Q1DG06)*/
> + [3] = {
> + _LCD_DECLARE(
> + 7, /* clock */
> + 320, 68, 66, 4, /* xres, margin_right, margin_left, hsync */
> + 240, 4, 4, 9, /* yres, margin_top, margin_bottom, vsync */
> + 60), /* refresh rate */
> + .lcdcon5 = (S3C2410_LCDCON5_FRM565 |
> + S3C2410_LCDCON5_INVVDEN |
> + S3C2410_LCDCON5_INVVFRAME |
> + S3C2410_LCDCON5_INVVLINE |
> + S3C2410_LCDCON5_INVVCLK |
> + S3C2410_LCDCON5_HWSWP),
> + },
> };
The patch has all tabs converted to spaces. Didn't notice it the first
time as well... :-/
WBR, Sergei
next prev parent reply other threads:[~2011-06-16 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:31 [PATCH] arm mach-s3c2440 mach-mini2440: New LCD-W35i support Denis Kuzmenko
2011-06-16 11:34 ` Sergei Shtylyov [this message]
2011-06-16 18:35 ` Denis Kuzmenko
2011-06-17 11:42 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2011-06-13 21:21 Денис Кузьменко
2011-06-14 10:51 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF9EA45.3020101@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=list@solonet.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox