From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406Ab1FTSzL (ORCPT ); Mon, 20 Jun 2011 14:55:11 -0400 Received: from slimlogic.co.uk ([89.16.172.20]:37159 "EHLO slimlogic.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1FTSzI (ORCPT ); Mon, 20 Jun 2011 14:55:08 -0400 Message-ID: <4DFF9784.8000604@slimlogic.co.uk> Date: Mon, 20 Jun 2011 20:55:00 +0200 From: Graeme Gregory User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Mark Brown CC: Samuel Ortiz , Liam Girdwood , Jorge Eduardo Candelaria , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: Implement tps65910 IRQ cleanup References: <1308566875-17441-1-git-send-email-broonie@opensource.wolfsonmicro.com> In-Reply-To: <1308566875-17441-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2011 12:47 PM, Mark Brown wrote: > The tps65910_irq_exit() cleanup function was generating a warning from > sparse due to the lack of a prototype. This wasn't causing GCC warnings > as the driver wasn't cleaning up its IRQs on exit at all so there was no > use of an unprototyped function. > > Signed-off-by: Mark Brown > --- > drivers/mfd/tps65910.c | 1 + > include/linux/mfd/tps65910.h | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c > index 2229e66..837f0e6 100644 > --- a/drivers/mfd/tps65910.c > +++ b/drivers/mfd/tps65910.c > @@ -187,6 +187,7 @@ static int tps65910_i2c_remove(struct i2c_client *i2c) > struct tps65910 *tps65910 = i2c_get_clientdata(i2c); > > mfd_remove_devices(tps65910->dev); > + tps65910_irq_exit(tps65910); > kfree(tps65910); > > return 0; > diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h > index 8bb85b9..efcdb29 100644 > --- a/include/linux/mfd/tps65910.h > +++ b/include/linux/mfd/tps65910.h > @@ -791,6 +791,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask); > void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base); > int tps65910_irq_init(struct tps65910 *tps65910, int irq, > struct tps65910_platform_data *pdata); > +int tps65910_irq_exit(struct tps65910 *tps65910); > > static inline int tps65910_chip_id(struct tps65910 *tps65910) > { Acked-by: Graeme Gregory Thanks for that cleanup. Graeme