From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Samuel Oritz <sameo@linux.intel.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH 2/8] regmap: Add I2C bus support
Date: Tue, 21 Jun 2011 01:22:55 +0200 [thread overview]
Message-ID: <4DFFD64F.8040902@metafoo.de> (raw)
In-Reply-To: <1308574489-31322-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On 06/20/2011 02:54 PM, Mark Brown wrote:
> [...]
> +
> +#include <linux/regmap.h>
> +#include <linux/i2c.h>
#include <linux/init.h>
> [...]
> +
> +static int regmap_i2c_read(struct device *dev,
> + const void *reg, size_t reg_size,
> + void *val, size_t val_size)
> +{
> + struct i2c_client *i2c = to_i2c_client(dev);
> + struct i2c_msg xfer[2];
> + int ret;
> +
> + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING))
> + return -ENOTSUPP;
You shouldn't need I2C_FUNC_PROTOCOL_MANGLING for reading.
> [...]
> diff --git a/drivers/regmap/regmap.c b/drivers/regmap/regmap.c
> index a8610c7..896b710 100644
> --- a/drivers/regmap/regmap.c
> +++ b/drivers/regmap/regmap.c
> @@ -461,7 +461,7 @@ out:
> [...]
I guess this should be part of the first patch.
next prev parent reply other threads:[~2011-06-20 23:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 12:46 [PATCH 0/8] Generic I2C and SPI register map library Mark Brown
2011-06-20 12:54 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-20 12:54 ` [PATCH 2/8] regmap: Add I2C bus support Mark Brown
2011-06-20 23:22 ` Lars-Peter Clausen [this message]
2011-06-20 23:41 ` Mark Brown
2011-06-21 0:01 ` Lars-Peter Clausen
2011-06-20 12:54 ` [PATCH 3/8] regmap: Add SPI " Mark Brown
2011-06-20 23:26 ` Lars-Peter Clausen
2011-06-20 23:45 ` Mark Brown
2011-06-21 0:00 ` Lars-Peter Clausen
2011-06-20 12:54 ` [PATCH 4/8] ASoC: Use new register map API for ASoC generic physical I/O Mark Brown
2011-06-20 12:54 ` [PATCH 5/8] mfd: Convert WM831x to use regmap API Mark Brown
2011-06-20 12:54 ` [PATCH 6/8] mfd: Convert WM8994 to use new register map API Mark Brown
2011-06-20 12:54 ` [PATCH 7/8] mfd: Convert pcf50633 " Mark Brown
2011-06-20 12:54 ` [PATCH 8/8] regulator: Convert tps65023 to use regmap API Mark Brown
2011-06-20 23:15 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Lars-Peter Clausen
2011-06-21 0:14 ` Mark Brown
2011-06-21 0:45 ` Lars-Peter Clausen
2011-06-21 1:24 ` Mark Brown
2011-06-21 11:47 ` Dimitris Papastamos
2011-06-21 12:07 ` Mark Brown
2011-06-21 11:43 ` Dimitris Papastamos
2011-06-21 12:07 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-06-22 18:44 [PATCH 0/8] Generic I2C and SPI register map library Mark Brown
2011-06-22 18:45 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-22 18:45 ` [PATCH 2/8] regmap: Add I2C bus support Mark Brown
2011-06-30 5:58 [PATCH 0/8] regmap: Generic I2C and SPI register map library Mark Brown
2011-06-30 6:00 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-30 6:00 ` [PATCH 2/8] regmap: Add I2C bus support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFFD64F.8040902@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox