From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757195Ab1FUUHO (ORCPT ); Tue, 21 Jun 2011 16:07:14 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:47902 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991Ab1FUUHM (ORCPT ); Tue, 21 Jun 2011 16:07:12 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=rl/oUaRL60Bux9aHB17ohVslKr6SQ7zAtkHcLw06mxu5qHBAwe8eSwHU3ZKvJUuX9w S0mOcjses/xukXrA8BZqZLpbssc7YKOpvIJQUhl5de2JvZxr7KKCDP89VCHi7cbpscR1 OKXmCC5t89qeyTOFEpXtU25/XttkhLdau28EQ= Message-ID: <4E00F9ED.1020500@gmail.com> Date: Tue, 21 Jun 2011 15:07:09 -0500 From: Rob Herring User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Grant Likely CC: Nicolas Pitre , devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Benjamin Herrenschmidt , Russell King , Arnd Bergmann Subject: Re: [PATCH 3/5] drivers/amba: create devices from device tree References: <20110621181127.18176.1384.stgit@ponder> <20110621184503.18176.88260.stgit@ponder> In-Reply-To: <20110621184503.18176.88260.stgit@ponder> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Grant, On 06/21/2011 01:45 PM, Grant Likely wrote: > Add a function to create amba_devices (i.e. primecell peripherals) > from device tree nodes. The device tree scanning is done by the > of_platform_populate() function which can call of_amba_device_create > based on a match table entry. > > Nodes with a "arm,primecell-periphid" property can override the h/w > peripheral id value. > > Based on the original work by Jeremy Kerr. > > Signed-off-by: Jeremy Kerr > Acked-by: Linus Walleij > Signed-off-by: Rob Herring > Reviewed-by: Arnd Bergmann > [grant.likely: add Jeremy's original s-o-b line, changes from review > comments, and moved all code to drivers/of/platform.c] > Signed-off-by: Grant Likely > --- > .../devicetree/bindings/arm/primecell.txt | 21 ++++++ > drivers/of/platform.c | 71 ++++++++++++++++++++ > 2 files changed, 92 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/primecell.txt > > diff --git a/Documentation/devicetree/bindings/arm/primecell.txt b/Documentation/devicetree/bindings/arm/primecell.txt > new file mode 100644 > index 0000000..1d5d7a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/primecell.txt > @@ -0,0 +1,21 @@ > +* ARM Primecell Peripherals > + > +ARM, Ltd. Primecell peripherals have a standard id register that can be used to > +identify the peripheral type, vendor, and revision. This value can be used for > +driver matching. > + > +Required properties: > + > +- compatible : should be a specific value for peripheral and "arm,primecell" Can I review what I wrote... Perhaps we should put strings in for all existing drivers in the kernel. This should be a complete list: arm,pl010 arm,pl011 st,pl011 arm,pl022 st,pl022 st,pl023 arm,pl030 arm,pl031 st,pl031 arm,pl061 arm,pl050 arm,pl080 arm,pl081 st,pl080 arm,pl110 arm,pl180 arm,pl330 arm,sp804 arm,sp805 Otherwise, they may never get added. Rob