Re: [patch 00/16] CFS Bandwidth Control v7

Ingo Molnar
2011-06-23T12:43:43Z

* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Wed, 2011-06-22 at 19:05 +0900, Hidetoshi Seto wrote:
>
> > I'll continue my test/benchmark on this v7 for a while. Though I
> > believe no more bug is there, I'll let you know if there is
> > something.
>
> Would that testing include performance of a kernel without these
> patches vs one with these patches in a configuration where the new
> feature is compiled in but not used?
>
> It does add a number of if (!cfs_rq->runtime_enabled) return
> branches all over the place, some possibly inside a function call
> (depending on what the auto-inliner does). So while the impact
> should be minimal, it would be very good to test it is indeed so.

Yeah, doing such performance tests is absolutely required. Branches
and instructions impact should be measured as well, beyond the cycles
impact.

The changelog of this recent commit:

c8b281161dfa: sched: Increase SCHED_LOAD_SCALE resolution

gives an example of how to do such measurements.

Thanks,

Ingo