Re: [PATCH 2/6] oom: improve dump_tasks() show items

David Rientjes
2011-06-22T22:59:47Z

On Wed, 22 Jun 2011, KOSAKI Motohiro wrote:

> Recently, oom internal logic was dramatically changed. Thus
> dump_tasks() doesn't show enough information for bug report
> analysis. it has some meaningless items and don't have some
> oom socre related items.
>
> This patch adapt displaying fields to new oom logic.
>
> details
> --------
> removed: pid (we always kill process. don't need thread id),
> signal->oom_adj (we no longer uses it internally)
> cpu (we no longer uses it)
> added: ppid (we often kill sacrifice child process)
> swap (it's accounted)
> modify: RSS (account mm->nr_ptes too)
>
> <old>
> [ pid ] uid tgid total_vm rss cpu oom_adj oom_score_adj name
> [ 3886] 0 3886 2893 441 1 0 0 bash
> [ 3905] 0 3905 29361 25833 0 0 0 memtoy
>
> <new>
> [ pid] ppid uid euid total_vm rss swap score_adj name
> [ 417] 1 0 0 3298 12 184 -1000 udevd
> [ 830] 1 0 0 1776 11 16 0 system-setup-ke
> [ 973] 1 0 0 61179 35 116 0 rsyslogd
> [ 1733] 1732 0 0 1052337 958582 0 0 memtoy
>

I like this very much! I'm always supportive of providing additional
information that will allow users to investigate oom conditions more
thoroughly.

I'm not sure that we should be exporting the euid, however, since I
disagreed with using it in the badness heuristic of the first patch.
Let's talk about it there and then perhaps it can be removed from the
tasklist dump if we don't actually end up using it?

Otherwise, it looks good!