From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>, Liam Girdwood <lrg@ti.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH 1/8] regmap: Add generic non-memory mapped register access API
Date: Wed, 22 Jun 2011 21:03:14 +0200 [thread overview]
Message-ID: <4E023C72.3030109@metafoo.de> (raw)
In-Reply-To: <1308768353-19372-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 06/22/2011 08:45 PM, Mark Brown wrote:
> [...]
> +
> +static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
> + unsigned int val_len)
> +{
> + u8 *u8 = map->work_buf;
> + int ret;
> +
> + map->format.format_reg(map->work_buf, reg);
> +
> + /*
> + * Some buses flag reads by setting the high bits in the
> + * register addresss; since it's always the high bits for all
> + * current formats we can do this here rather than in
> + * formatting. This may break if we get interesting formats.
> + */
> + if (map->bus->read_flag_bit)
> + u8[0] |= 1 << map->bus->read_flag_bit;
Should be 1 << (map->bus->read_flag_bit - 1)
next prev parent reply other threads:[~2011-06-22 19:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 18:44 [PATCH 0/8] Generic I2C and SPI register map library Mark Brown
2011-06-22 18:45 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-22 18:45 ` [PATCH 2/8] regmap: Add I2C bus support Mark Brown
2011-06-22 18:45 ` [PATCH 3/8] regmap: Add SPI " Mark Brown
2011-06-22 18:45 ` [PATCH 4/8] ASoC: Use new register map API for ASoC generic physical I/O Mark Brown
2011-06-22 18:45 ` [PATCH 5/8] mfd: Convert WM831x to use regmap API Mark Brown
2011-06-22 18:45 ` [PATCH 6/8] mfd: Convert WM8994 to use new register map API Mark Brown
2011-06-22 18:45 ` [PATCH 7/8] mfd: Convert pcf50633 " Mark Brown
2011-06-22 18:45 ` [PATCH 8/8] regulator: Convert tps65023 to use regmap API Mark Brown
2011-06-22 19:03 ` Lars-Peter Clausen [this message]
2011-06-22 19:11 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-22 19:20 ` Lars-Peter Clausen
2011-06-22 19:42 ` Mark Brown
2011-07-01 0:22 ` Ben Hutchings
2011-07-01 2:38 ` Mark Brown
2011-06-22 22:48 ` [PATCH 0/8] Generic I2C and SPI register map library torbenh
2011-06-23 1:25 ` Mark Brown
2011-06-23 8:54 ` Jonathan Cameron
2011-06-23 10:44 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-06-30 5:58 [PATCH 0/8] regmap: " Mark Brown
2011-06-30 6:00 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-20 12:46 [PATCH 0/8] Generic I2C and SPI register map library Mark Brown
2011-06-20 12:54 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-20 23:15 ` Lars-Peter Clausen
2011-06-21 0:14 ` Mark Brown
2011-06-21 0:45 ` Lars-Peter Clausen
2011-06-21 1:24 ` Mark Brown
2011-06-21 11:47 ` Dimitris Papastamos
2011-06-21 12:07 ` Mark Brown
2011-06-21 11:43 ` Dimitris Papastamos
2011-06-21 12:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E023C72.3030109@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox