From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pch_uart: Add MSI support
Date: Thu, 23 Jun 2011 09:14:52 +0900 [thread overview]
Message-ID: <4E02857C.1010304@dsn.okisemi.com> (raw)
In-Reply-To: <1308736219-19975-1-git-send-email-alexander.stein@systec-electronic.com>
(2011/06/22 18:50), Alexander Stein wrote:
> Signed-off-by: Alexander Stein<alexander.stein@systec-electronic.com>
> ---
> drivers/tty/serial/pch_uart.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
> index 4652109..9db9773 100644
> --- a/drivers/tty/serial/pch_uart.c
> +++ b/drivers/tty/serial/pch_uart.c
> @@ -234,6 +234,7 @@ struct eg20t_port {
> int tx_dma_use;
> void *rx_buf_virt;
> dma_addr_t rx_buf_dma;
> + int use_msi;
> };
>
> /**
> @@ -1429,6 +1430,12 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
> goto init_port_hal_free;
> }
>
> + ret = pci_enable_msi(pdev);
> + if (ret)
> + priv->use_msi = 0;
> + else
> + priv->use_msi = 1;
> +
> iobase = pci_resource_start(pdev, 0);
> mapbase = pci_resource_start(pdev, 1);
> priv->mapbase = mapbase;
> @@ -1485,6 +1492,9 @@ static void pch_uart_pci_remove(struct pci_dev *pdev)
> struct eg20t_port *priv;
>
> priv = (struct eg20t_port *)pci_get_drvdata(pdev);
> +
> + if (priv->use_msi)
> + pci_disable_msi(pdev);
> pch_uart_exit_port(priv);
> pci_disable_device(pdev);
> kfree(priv);
> @@ -1568,6 +1578,8 @@ static int __devinit pch_uart_pci_probe(struct pci_dev *pdev,
> return ret;
>
> probe_disable_device:
> + if (priv->use_msi)
> + pci_disable_msi(pdev);
> pci_disable_device(pdev);
> probe_error:
> return ret;
Thank you for your updating.
--
tomoya
OKI SEMICONDUCTOR CO., LTD.
next prev parent reply other threads:[~2011-06-23 0:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 9:50 [PATCH] pch_uart: Add MSI support Alexander Stein
2011-06-23 0:14 ` Tomoya MORINAGA [this message]
2011-06-23 7:00 ` [PATCH v2] " Alexander Stein
2011-06-23 7:16 ` Clemens Ladisch
2011-06-23 7:37 ` Alexander Stein
2011-07-01 22:32 ` Greg KH
2011-07-04 6:58 ` [PATCH v3] " Alexander Stein
2011-07-22 12:39 ` Tomoya MORINAGA
2011-07-19 4:15 ` serial/pch_uart: AT command behavior Tomoya MORINAGA
2011-07-19 9:06 ` Alan Cox
2011-07-20 0:14 ` Tomoya MORINAGA
2011-07-20 12:49 ` Alan Cox
2011-06-23 0:34 ` [PATCH] pch_uart: Add MSI support Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E02857C.1010304@dsn.okisemi.com \
--to=tomoya-linux@dsn.okisemi.com \
--cc=alan@linux.intel.com \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox