public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
	Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>, Samuel Oritz <sameo@linux.intel.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH 0/8] Generic I2C and SPI register map library
Date: Thu, 23 Jun 2011 09:54:25 +0100	[thread overview]
Message-ID: <4E02FF41.1060000@cam.ac.uk> (raw)
In-Reply-To: <20110623012544.GE20949@opensource.wolfsonmicro.com>

On 06/23/11 02:25, Mark Brown wrote:
> On Thu, Jun 23, 2011 at 12:48:28AM +0200, torbenh wrote:
> 
>> you should look at SMBus 
>> there seems to be quite some code to share.
>> in particular i2c rtc devices seem to be using SMBus functions
>> to get the exact same semantics you are providing here.
> 
> SMBus is an I2C subset with a definition for 8 bit registers layered
> onto it, pretty much.
> 
>> I just added support for such a device today, and it struck me, that
>> this API was necessary.
> 
> If you're only using SMBus then the I2C interface includes SMBus based
> register support which should do what you want.  With the regmap API it
> ought to work as a device with 8 bit registers and 8 bit values.

The kicker here is that quite a few hosts only support the smbus subset.
How should that be handled here?

  reply	other threads:[~2011-06-23  8:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 18:44 [PATCH 0/8] Generic I2C and SPI register map library Mark Brown
2011-06-22 18:45 ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Mark Brown
2011-06-22 18:45   ` [PATCH 2/8] regmap: Add I2C bus support Mark Brown
2011-06-22 18:45   ` [PATCH 3/8] regmap: Add SPI " Mark Brown
2011-06-22 18:45   ` [PATCH 4/8] ASoC: Use new register map API for ASoC generic physical I/O Mark Brown
2011-06-22 18:45   ` [PATCH 5/8] mfd: Convert WM831x to use regmap API Mark Brown
2011-06-22 18:45   ` [PATCH 6/8] mfd: Convert WM8994 to use new register map API Mark Brown
2011-06-22 18:45   ` [PATCH 7/8] mfd: Convert pcf50633 " Mark Brown
2011-06-22 18:45   ` [PATCH 8/8] regulator: Convert tps65023 to use regmap API Mark Brown
2011-06-22 19:03   ` [PATCH 1/8] regmap: Add generic non-memory mapped register access API Lars-Peter Clausen
2011-06-22 19:11     ` Mark Brown
2011-06-22 19:20       ` Lars-Peter Clausen
2011-06-22 19:42         ` Mark Brown
2011-07-01  0:22   ` Ben Hutchings
2011-07-01  2:38     ` Mark Brown
2011-06-22 22:48 ` [PATCH 0/8] Generic I2C and SPI register map library torbenh
2011-06-23  1:25   ` Mark Brown
2011-06-23  8:54     ` Jonathan Cameron [this message]
2011-06-23 10:44       ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2011-06-20 12:46 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E02FF41.1060000@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=khali@linux-fr.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox