From: Pavel Roskin <proski@gnu.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
linux-wireless@vger.kernel.org, linux-next@vger.kernel.org,
"Linux Kernel Development" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] bcma: main.c needs to include <linux/slab.h>
Date: Mon, 27 Jun 2011 10:44:00 -0400 [thread overview]
Message-ID: <4E089730.1080306@gnu.org> (raw)
In-Reply-To: <BANLkTinGvM79fza-=bFwcbtfFzGHAVKJag@mail.gmail.com>
On 06/27/2011 10:24 AM, Alexey Dobriyan wrote:
> 2011/6/27 Rafał Miłecki<zajec5@gmail.com>:
>> 2011/6/26 Geert Uytterhoeven<geert@linux-m68k.org>:
>>> m68k allmodconfig:
>>>
>>> drivers/bcma/main.c: In function ‘bcma_release_core_dev’:
>>> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’
>>
>> We already include slab.h in:
>> host_pci.c
>> scan.c
>> sprom.c
>>
>> Maybe we can just include this in bcma.h as a better solution?
>
> It isn't better solution.
> It results in situation where unnecessary inclusion will be done.
> Maybe it's not the case now, but it will be in future.
I agree. kfree() is used in main.c, not in bcma.h. There is no need
for all files that include bcma.h to include linux/slab.h, especially
(but not only) because bcma.h is not a private header.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-06-27 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 8:19 [PATCH -next] bcma: main.c needs to include <linux/slab.h> Geert Uytterhoeven
2011-06-27 13:59 ` Rafał Miłecki
2011-06-27 14:09 ` Geert Uytterhoeven
2011-06-27 14:11 ` Rafał Miłecki
2011-06-27 14:24 ` Alexey Dobriyan
2011-06-27 14:43 ` Rafał Miłecki
2011-06-27 16:49 ` Arend van Spriel
2011-06-27 16:57 ` Johannes Berg
2011-06-27 17:22 ` Pavel Roskin
2011-06-27 14:44 ` Pavel Roskin [this message]
2011-06-27 14:49 ` Rafał Miłecki
2011-06-27 14:53 ` Geert Uytterhoeven
2011-06-27 15:00 ` Rafał Miłecki
2011-06-28 7:58 ` Rafał Miłecki
2011-06-28 9:49 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E089730.1080306@gnu.org \
--to=proski@gnu.org \
--cc=adobriyan@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox