From: Ben Greear <greearb@candelatech.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH 2/2] slub: Add method to verify memory is not deleted.
Date: Mon, 27 Jun 2011 17:18:51 -0700 [thread overview]
Message-ID: <4E091DEB.7010000@candelatech.com> (raw)
In-Reply-To: <4E091670.9040405@candelatech.com>
On 06/27/2011 04:46 PM, Ben Greear wrote:
>> Did you even compile-test this?
>
> Well yes, but obviously I'm having a bad day!
>
> Aside from the lame mistakes in my patch..is the general approach
> usable?
I was missing slab_lock() around the on_freelist() call,
that is probably why I got the printouts about object count
being off.
Fixing that and will let it cook overnight.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2011-06-28 0:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 23:17 [PATCH 0/2] SLUB memory debugging improvements greearb
2011-06-27 23:17 ` [PATCH 1/2] slub: Enable backtrace for create/delete points greearb
2011-06-27 23:17 ` [PATCH 2/2] slub: Add method to verify memory is not deleted greearb
2011-06-27 23:28 ` David Rientjes
2011-06-27 23:46 ` Ben Greear
2011-06-28 0:18 ` Ben Greear [this message]
2011-06-28 0:19 ` David Rientjes
2011-06-28 0:24 ` Ben Greear
2011-06-28 3:45 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E091DEB.7010000@candelatech.com \
--to=greearb@candelatech.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox